[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 02/26] qcow2: remove incorrect coroutine_fn annotations
From: |
Eric Blake |
Subject: |
Re: [PATCH v2 02/26] qcow2: remove incorrect coroutine_fn annotations |
Date: |
Tue, 10 May 2022 10:04:50 -0500 |
User-agent: |
NeoMutt/20220429-35-ca2e7f |
On Mon, May 09, 2022 at 12:29:55PM +0200, Paolo Bonzini wrote:
> This is incorrect because qcow2_mark_clean() calls qcow2_flush_caches().
> qcow2_mark_clean() is called from non-coroutine context in
> qcow2_inactivate() and qcow2_close().
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> block/qcow2-refcount.c | 4 ++--
> block/qcow2.h | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
- [PATCH v2 00/26] block: fix coroutine_fn annotations, Paolo Bonzini, 2022/05/09
- [PATCH v2 03/26] nbd: remove incorrect coroutine_fn annotations, Paolo Bonzini, 2022/05/09
- [PATCH v2 02/26] qcow2: remove incorrect coroutine_fn annotations, Paolo Bonzini, 2022/05/09
- Re: [PATCH v2 02/26] qcow2: remove incorrect coroutine_fn annotations,
Eric Blake <=
- [PATCH v2 01/26] block: remove incorrect coroutine_fn annotations, Paolo Bonzini, 2022/05/09
- [PATCH v2 05/26] blkdebug: add missing coroutine_fn annotations, Paolo Bonzini, 2022/05/09
- [PATCH v2 06/26] blkverify: add missing coroutine_fn annotations, Paolo Bonzini, 2022/05/09
- [PATCH v2 04/26] coroutine: remove incorrect coroutine_fn annotations, Paolo Bonzini, 2022/05/09
- [PATCH v2 07/26] block: add missing coroutine_fn annotations, Paolo Bonzini, 2022/05/09