Re: [PATCH 0/6] hppa: Artist graphics driver fixes for HP-UX

[Mark Cave-Ayland]

On 12/05/2022 00:50, Helge Deller wrote:

> This series adds additional HP fonts to the SeaBIOS-hppa firmware.
>
> And in the qemu artist graphics driver it:
> - fixes the vertical postioning of the X11 cursor with HP-UX
> - allows X11 to blank the screen (e.g. screensaver)
> - allows the X11 driver to turn the X11 cursor on/off
>
> Signed-off-by: Helge Deller <deller@gmx.de>
>
> Helge Deller (6):
>    seabios-hppa: Update SeaBIOS-hppa to VERSION 4
>    artist: Introduce constant for max cursor size
>    artist: Use human-readable variable names instead of reg_xxx
>    artist: Fix vertical X11 cursor position in HP-UX
>    artist: Allow to turn cursor on or off
>    artist: Emulate screen blanking
>
>   hw/display/artist.c       | 134 +++++++++++++++++++++++++++++---------
>   pc-bios/hppa-firmware.img | Bin 701964 -> 715240 bytes
>   roms/seabios-hppa         |   2 +-
>   3 files changed, 106 insertions(+), 30 deletions(-)
>
> --
> 2.35.3

I've applied these patches to latest git and done a quick test with my cut-down Linux 
image and the latest HPPA image at https://parisc.wiki.kernel.org/index.php/Qemu, and 
confirmed I can successfully switch fonts without seeing any other graphical issues. 
This isn't a particularly comprehensive test though, since I don't have a copy of 
HP-UX and the latest HPPA image doesn't have X installed.

From a general QEMU perspective the patches look okay, except for the separate patch 
posted after the original series which fails checkpatch due to styling issues around 
the block comments. It is possible to do this directly on a checkout of the git 
source tree with "./scripts/checkpatch.pl master..HEAD", or once you have the final 
PR ready to go then a push to GitLab to confirm it passes CI should help locate any 
potential problems.

I don't have any knowledge of the internals of the artist framebuffer, but feel free 
to add an:

Acked-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>

when you respin the v2. It's not far off a Tested-by but I don't feel I can offer 
that without being able to test a HP-UX X environment.


ATB,

Mark.