[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 06/15] qga: use qemu_open_cloexec() for safe_open_or_creat
|
From: |
Markus Armbruster |
|
Subject: |
Re: [PATCH v3 06/15] qga: use qemu_open_cloexec() for safe_open_or_create() |
|
Date: |
Mon, 16 May 2022 09:24:18 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
marcandre.lureau@redhat.com writes:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> The function takes care of setting CLOEXEC, and reporting error.
>
> The reported error message will differ, from:
> "failed to open file 'foo' (mode: 'r')"
> to:
> "Failed to open file 'foo'"
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
I don't like the first message's "(mode: 'r')", because it talks code to
the user. Better: "for reading". I'm not sure how useful the "for
reading" bit of information is here. You decide.
Reviewed-by: Markus Armbruster <armbru@redhat.com>
- [PATCH v3 00/15] Misc cleanups, marcandre . lureau, 2022/05/13
- [PATCH v3 01/15] include: move qemu_*_exec_dir() to cutils, marcandre . lureau, 2022/05/13
- [PATCH v3 02/15] util/win32: simplify qemu_get_local_state_dir(), marcandre . lureau, 2022/05/13
- [PATCH v3 03/15] tests: make libqmp buildable for win32, marcandre . lureau, 2022/05/13
- [PATCH v3 05/15] osdep: export qemu_open_cloexec(), marcandre . lureau, 2022/05/13
- [PATCH v3 04/15] qga: flatten safe_open_or_create(), marcandre . lureau, 2022/05/13
- [PATCH v3 06/15] qga: use qemu_open_cloexec() for safe_open_or_create(), marcandre . lureau, 2022/05/13
- Re: [PATCH v3 06/15] qga: use qemu_open_cloexec() for safe_open_or_create(),
Markus Armbruster <=
- [PATCH v3 07/15] qga: throw an Error in ga_channel_open(), marcandre . lureau, 2022/05/13
- [PATCH v3 08/15] qga: replace qemu_open_old() with qemu_open_cloexec(), marcandre . lureau, 2022/05/13
- [PATCH v3 09/15] qga: make build_fs_mount_list() return a bool, marcandre . lureau, 2022/05/13
- [PATCH v3 10/15] test/qga: use G_TEST_DIR to locate os-release test file, marcandre . lureau, 2022/05/13
- [PATCH v3 11/15] qga/wixl: prefer variables over environment, marcandre . lureau, 2022/05/13
- [PATCH v3 12/15] qga/wixl: require Mingw_bin, marcandre . lureau, 2022/05/13
- [PATCH v3 13/15] qga/wixl: simplify some pre-processing, marcandre . lureau, 2022/05/13