qemu-devel
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 07/74] semihosting: Split out guestfd.c

From: Richard Henderson
Subject: Re: [PATCH v2 07/74] semihosting: Split out guestfd.c
Date: Mon, 16 May 2022 18:47:21 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 
On 5/16/22 08:14, Peter Maydell wrote:

diff --git a/configs/targets/aarch64-linux-user.mak 
b/configs/targets/aarch64-linux-user.mak
index d0c603c54e..db552f1839 100644
--- a/configs/targets/aarch64-linux-user.mak
+++ b/configs/targets/aarch64-linux-user.mak
@@ -2,4 +2,5 @@ TARGET_ARCH=aarch64
  TARGET_BASE_ARCH=arm
  TARGET_XML_FILES= gdb-xml/aarch64-core.xml gdb-xml/aarch64-fpu.xml
  TARGET_HAS_BFLT=y
+CONFIG_SEMIHOSTING=y
  CONFIG_ARM_COMPATIBLE_SEMIHOSTING=y


Is it not possible to make CONFIG_ARM_COMPATIBLE_SEMIHOSTING=y
imply CONFIG_SEMIHOSTING=y somehow?


I don't think so -- Kconfig is only processed for softmmu.


If these are moving from being static functions local to a file
to being global, they should get kerneldoc style doc-comments here in
the header file.


Ok.

r~
reply via email to
[Prev in Thread] Current Thread [Next in Thread]