[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 03/16] build: add a more generic way to specify make->ninja depen
From: |
Paolo Bonzini |
Subject: |
[PATCH 03/16] build: add a more generic way to specify make->ninja dependencies |
Date: |
Tue, 17 May 2022 11:26:03 +0200 |
Let any make target specify ninja goals that needs to be built for it
(though selecting the goals is _not_ recursive on depending targets)
instead of having a custom mechanism only for "make check" and "make
bench".
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
Makefile | 3 +--
scripts/mtest2make.py | 8 ++++----
2 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/Makefile b/Makefile
index fad312040f..3c0d89057e 100644
--- a/Makefile
+++ b/Makefile
@@ -145,8 +145,7 @@ NINJAFLAGS = $(if $V,-v) $(if $(MAKE.n), -n) $(if
$(MAKE.k), -k0) \
$(filter-out -j, $(lastword -j1 $(filter -l% -j%, $(MAKEFLAGS)))) \
-d keepdepfile
ninja-cmd-goals = $(or $(MAKECMDGOALS), all)
-ninja-cmd-goals += $(foreach t, $(.check.build-suites), $(.check-$t.deps))
-ninja-cmd-goals += $(foreach t, $(.bench.build-suites), $(.bench-$t.deps))
+ninja-cmd-goals += $(foreach g, $(MAKECMDGOALS), $(.ninja-goals.$g))))
makefile-targets := build.ninja ctags TAGS cscope dist clean uninstall
# "ninja -t targets" also lists all prerequisites. If build system
diff --git a/scripts/mtest2make.py b/scripts/mtest2make.py
index 304634b71e..0fe81efbbc 100644
--- a/scripts/mtest2make.py
+++ b/scripts/mtest2make.py
@@ -81,12 +81,12 @@ def emit_prolog(suites, prefix):
def emit_suite_deps(name, suite, prefix):
deps = ' '.join(suite.deps)
- targets = f'{prefix}-{name} {prefix}-report-{name}.junit.xml {prefix}
{prefix}-report.junit.xml'
+ targets = [f'{prefix}-{name}', f'{prefix}-report-{name}.junit.xml',
f'{prefix}', f'{prefix}-report.junit.xml',
+ f'{prefix}-build']
print()
print(f'.{prefix}-{name}.deps = {deps}')
- print(f'ifneq ($(filter {prefix}-build {targets}, $(MAKECMDGOALS)),)')
- print(f'.{prefix}.build-suites += {name}')
- print(f'endif')
+ for t in targets:
+ print(f'.ninja-goals.{t} += $(.{prefix}-{name}.deps)')
def emit_suite(name, suite, prefix):
emit_suite_deps(name, suite, prefix)
--
2.36.0
- [PATCH 00/16] Cross compilation of embedded firmware, Paolo Bonzini, 2022/05/17
- [PATCH 01/16] configure: do not define or use the CPP variable, Paolo Bonzini, 2022/05/17
- [PATCH 02/16] build: clean up ninja invocation, Paolo Bonzini, 2022/05/17
- [PATCH 03/16] build: add a more generic way to specify make->ninja dependencies,
Paolo Bonzini <=
- [PATCH 04/16] build: do a full build before running TCG tests, Paolo Bonzini, 2022/05/17
- [PATCH 06/16] tests/tcg: correct target CPU for sparc32, Paolo Bonzini, 2022/05/17
- [PATCH 05/16] configure, meson: move symlinking of ROMs to meson, Paolo Bonzini, 2022/05/17
- [PATCH 07/16] tests/tcg: merge configure.sh back into main configure script, Paolo Bonzini, 2022/05/17
- [PATCH 09/16] configure: handle host compiler in probe_target_compiler, Paolo Bonzini, 2022/05/17
- [PATCH 10/16] configure: introduce --cross-prefix-*=, Paolo Bonzini, 2022/05/17