qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC PATCH] tests/qtest: pass stdout/stderr down to subtests


From: Thomas Huth
Subject: Re: [RFC PATCH] tests/qtest: pass stdout/stderr down to subtests
Date: Wed, 18 May 2022 09:34:10 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0

On 07/04/2022 17.00, Alex Bennée wrote:
When trying to work out what the virtio-net-tests where doing it was
hard because the g_test_trap_subprocess redirects all output to
/dev/null. Lift this restriction by using the appropriate flags so you
can see something similar to what the vhost-user-blk tests show when
running.

While we are at it remove the g_test_verbose() check so we always show
how the QEMU is run.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
  tests/qtest/qos-test.c | 7 +++----
  1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/tests/qtest/qos-test.c b/tests/qtest/qos-test.c
index f97d0a08fd..c6c196cc95 100644
--- a/tests/qtest/qos-test.c
+++ b/tests/qtest/qos-test.c
@@ -89,9 +89,7 @@ static void qos_set_machines_devices_available(void)
static void restart_qemu_or_continue(char *path)
  {
-    if (g_test_verbose()) {
-        qos_printf("Run QEMU with: '%s'\n", path);
-    }
+    qos_printf("Run QEMU with: '%s'\n", path);

I think I'd rather drop this hunk since it breaks the usual output of the qtests. And adding a --verbose when running the test isn't that hard either, is it?

 Thomas




reply via email to

[Prev in Thread] Current Thread [Next in Thread]