qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] linux-user: Clean up arg_start/arg_end confusion


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v2] linux-user: Clean up arg_start/arg_end confusion
Date: Sun, 22 May 2022 23:46:18 +0200
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0

On 27/4/22 04:51, Richard Henderson wrote:
We had two sets of variables: arg_start/arg_end, and
arg_strings/env_strings.  In linuxload.c, we set the
first pair to the bounds of the argv strings, but in
elfload.c, we set the first pair to the bounds of the
argv pointers and the second pair to the bounds of
the argv strings.

Remove arg_start/arg_end, replacing them with the standard
argc/argv/envc/envp values.  Retain arg_strings/env_strings
with the meaning we were using in elfload.c.

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/714
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
  linux-user/qemu.h             | 12 ++++++++----
  linux-user/elfload.c          | 10 ++++++----
  linux-user/linuxload.c        | 12 ++++++++++--
  linux-user/main.c             |  4 ++--
  semihosting/arm-compat-semi.c |  4 ++--
  5 files changed, 28 insertions(+), 14 deletions(-)

Nice simplification.

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]