[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 23/49] semihosting: Split out semihost_sys_open
From: |
Peter Maydell |
Subject: |
Re: [PATCH v3 23/49] semihosting: Split out semihost_sys_open |
Date: |
Mon, 23 May 2022 17:54:32 +0100 |
On Mon, 23 May 2022 at 16:46, Richard Henderson
<richard.henderson@linaro.org> wrote:
> Also, I think I mentioned this in the v2 cover but not here, that having done
> the errno
> conversion here for arm semihosting, it worked less well for mips and xtensa,
> which have a
> rather better defined set of errnos.
>
> My question from v2 was: should we in fact convert back from gdb's errno to
> host errno in
> gdbstub.c handle_file_io(), and then let each semihosting backend convert
> from host to guest?
That sounds like it's probably a better idea (though I'm not sure
what host errno we use for the gdb "unknown errno" case)...
-- PMM
- [PATCH v3 19/49] semihosting: Split common_semi_flen_buf per target, (continued)
- [PATCH v3 19/49] semihosting: Split common_semi_flen_buf per target, Richard Henderson, 2022/05/20
- [PATCH v3 27/49] semihosting: Bound length for semihost_sys_{read, write}, Richard Henderson, 2022/05/20
- [PATCH v3 33/49] semihosting: Split out semihost_sys_system, Richard Henderson, 2022/05/20
- [PATCH v3 36/49] gdbstub: Widen gdb_syscall_complete_cb return value, Richard Henderson, 2022/05/20
- [PATCH v3 03/49] semihosting: Improve condition for config.c and console.c, Richard Henderson, 2022/05/20
- [PATCH v3 23/49] semihosting: Split out semihost_sys_open, Richard Henderson, 2022/05/20
[PATCH v3 40/49] semihosting: Cleanup chardev init, Richard Henderson, 2022/05/20
[PATCH v3 42/49] semihosting: Add GuestFDConsole, Richard Henderson, 2022/05/20
[PATCH v3 43/49] semihosting: Create qemu_semihosting_guestfd_init, Richard Henderson, 2022/05/20
[PATCH v3 44/49] semihosting: Use console_in_gf for SYS_READC, Richard Henderson, 2022/05/20
[PATCH v3 46/49] semihosting: Remove qemu_semihosting_console_outc, Richard Henderson, 2022/05/20
[PATCH v3 41/49] semihosting: Create qemu_semihosting_console_write, Richard Henderson, 2022/05/20
[PATCH v3 45/49] semihosting: Use console_out_gf for SYS_WRITEC, Richard Henderson, 2022/05/20
[PATCH v3 47/49] semihosting: Use console_out_gf for SYS_WRITE0, Richard Henderson, 2022/05/20
[PATCH v3 49/49] semihosting: Create semihost_sys_poll_one, Richard Henderson, 2022/05/20