[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 08/15] qga: replace qemu_open_old() with qga_open_cloexec()
From: |
marcandre . lureau |
Subject: |
[PATCH v4 08/15] qga: replace qemu_open_old() with qga_open_cloexec() |
Date: |
Tue, 24 May 2022 12:34:46 +0200 |
From: Marc-André Lureau <marcandre.lureau@redhat.com>
qemu_open_old() uses qemu_open_internal() which handles special
"/dev/fdset/" path for monitor fd sets, set CLOEXEC, and uses Error
reporting (and some O_DIRECT special error casing).
The monitor fdset handling is unnecessary for qga, use
qga_open_cloexec() instead.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>
---
qga/channel-posix.c | 15 ++++++++++-----
qga/commands-posix.c | 25 +++++++++++++------------
2 files changed, 23 insertions(+), 17 deletions(-)
diff --git a/qga/channel-posix.c b/qga/channel-posix.c
index 25fcc5cb1a..6b9ab5191c 100644
--- a/qga/channel-posix.c
+++ b/qga/channel-posix.c
@@ -1,8 +1,10 @@
#include "qemu/osdep.h"
+#include "qemu/cutils.h"
#include <termios.h>
#include "qapi/error.h"
#include "qemu/sockets.h"
#include "channel.h"
+#include "cutils.h"
#ifdef CONFIG_SOLARIS
#include <stropts.h>
@@ -127,11 +129,15 @@ static gboolean ga_channel_open(GAChannel *c, const gchar
*path,
switch (c->method) {
case GA_CHANNEL_VIRTIO_SERIAL: {
assert(fd < 0);
- fd = qemu_open_old(path, O_RDWR | O_NONBLOCK
+ fd = qga_open_cloexec(
+ path,
#ifndef CONFIG_SOLARIS
- | O_ASYNC
+ O_ASYNC |
#endif
- );
+ O_RDWR | O_NONBLOCK,
+ 0,
+ errp
+ );
if (fd == -1) {
error_setg_errno(errp, errno, "error opening channel");
return false;
@@ -156,9 +162,8 @@ static gboolean ga_channel_open(GAChannel *c, const gchar
*path,
struct termios tio;
assert(fd < 0);
- fd = qemu_open_old(path, O_RDWR | O_NOCTTY | O_NONBLOCK);
+ fd = qga_open_cloexec(path, O_RDWR | O_NOCTTY | O_NONBLOCK, 0, errp);
if (fd == -1) {
- error_setg_errno(errp, errno, "error opening channel");
return false;
}
tcgetattr(fd, &tio);
diff --git a/qga/commands-posix.c b/qga/commands-posix.c
index 28fe19d932..e3b893cd47 100644
--- a/qga/commands-posix.c
+++ b/qga/commands-posix.c
@@ -1394,6 +1394,7 @@ static GuestDiskInfoList *get_disk_partitions(
static void get_nvme_smart(GuestDiskInfo *disk)
{
+ Error *err = NULL;
int fd;
GuestNVMeSmart *smart;
NvmeSmartLog log = {0};
@@ -1406,9 +1407,10 @@ static void get_nvme_smart(GuestDiskInfo *disk)
| (((sizeof(log) >> 2) - 1) << 16)
};
- fd = qemu_open_old(disk->name, O_RDONLY);
+ fd = qga_open_cloexec(disk->name, O_RDONLY, 0, &err);
if (fd == -1) {
- g_debug("Failed to open device: %s: %s", disk->name,
g_strerror(errno));
+ g_debug("Failed to open device: %s: %s", disk->name,
error_get_pretty(err));
+ error_free(err);
return;
}
@@ -1739,9 +1741,8 @@ int64_t qmp_guest_fsfreeze_freeze_list(bool
has_mountpoints,
}
}
- fd = qemu_open_old(mount->dirname, O_RDONLY);
+ fd = qga_open_cloexec(mount->dirname, O_RDONLY, 0, errp);
if (fd == -1) {
- error_setg_errno(errp, errno, "failed to open %s", mount->dirname);
goto error;
}
@@ -1806,7 +1807,7 @@ int64_t qmp_guest_fsfreeze_thaw(Error **errp)
QTAILQ_FOREACH(mount, &mounts, next) {
logged = false;
- fd = qemu_open_old(mount->dirname, O_RDONLY);
+ fd = qga_open_cloexec(mount->dirname, O_RDONLY, 0, NULL);
if (fd == -1) {
continue;
}
@@ -1866,21 +1867,20 @@ static void guest_fsfreeze_cleanup(void)
GuestFilesystemTrimResponse *
qmp_guest_fstrim(bool has_minimum, int64_t minimum, Error **errp)
{
+ ERRP_GUARD();
GuestFilesystemTrimResponse *response;
GuestFilesystemTrimResult *result;
int ret = 0;
FsMountList mounts;
struct FsMount *mount;
int fd;
- Error *local_err = NULL;
struct fstrim_range r;
slog("guest-fstrim called");
QTAILQ_INIT(&mounts);
- build_fs_mount_list(&mounts, &local_err);
- if (local_err) {
- error_propagate(errp, local_err);
+ build_fs_mount_list(&mounts, errp);
+ if (*errp) {
return NULL;
}
@@ -1892,11 +1892,12 @@ qmp_guest_fstrim(bool has_minimum, int64_t minimum,
Error **errp)
QAPI_LIST_PREPEND(response->paths, result);
- fd = qemu_open_old(mount->dirname, O_RDONLY);
+ fd = qga_open_cloexec(mount->dirname, O_RDONLY, 0, errp);
if (fd == -1) {
- result->error = g_strdup_printf("failed to open: %s",
- strerror(errno));
+ result->error = g_strdup(error_get_pretty(*errp));
result->has_error = true;
+ error_free(*errp);
+ *errp = NULL;
continue;
}
--
2.36.1
- Re: [PATCH v4 05/15] qga: add qga_open_cloexec() helper, (continued)
- [PATCH v4 12/15] qga/wixl: require Mingw_bin, marcandre . lureau, 2022/05/24
- [PATCH v4 09/15] qga: make build_fs_mount_list() return a bool, marcandre . lureau, 2022/05/24
- [PATCH v4 13/15] qga/wixl: simplify some pre-processing, marcandre . lureau, 2022/05/24
- [PATCH v4 11/15] qga/wixl: prefer variables over environment, marcandre . lureau, 2022/05/24
- [PATCH v4 14/15] qga/wixl: replace QEMU_GA_MSI_MINGW_BIN_PATH with glib bindir, marcandre . lureau, 2022/05/24
- [PATCH v4 02/15] util/win32: simplify qemu_get_local_state_dir(), marcandre . lureau, 2022/05/24
- [PATCH v4 06/15] qga: use qga_open_cloexec() for safe_open_or_create(), marcandre . lureau, 2022/05/24
- [PATCH v4 04/15] qga: flatten safe_open_or_create(), marcandre . lureau, 2022/05/24
- [PATCH v4 08/15] qga: replace qemu_open_old() with qga_open_cloexec(),
marcandre . lureau <=
- [PATCH v4 10/15] test/qga: use G_TEST_DIR to locate os-release test file, marcandre . lureau, 2022/05/24