Re: [PATCH 00/16] Cross compilation of embedded firmware

[Alex Bennée]

Paolo Bonzini <pbonzini@redhat.com> writes:

> This is the next part of the firmware cross compilation story.  It only
> looks at firmware that's strictly part of QEMU (optionrom, s390-ccw,
> vof), and does not do docker cross compilers yet; but it takes the
> infrastructure from tests/tcg/configure.sh and moves it in the main
> configure script so that others can use it.
>
> I actually expect the compiler tests to move back to tests/tcg, running
> at Make time after the docker images are built.  For now, the file is
> moved as a whole, including both compiler detection and the tests.

Isn't that just creating a bunch of unnecessary churn? The
tests/tcg/configure.sh sciprt already has a bunch of special casing in
it to detect various compiler features for the purposes of tests. It
would be nice if we could keep it's history of warts intact.

>
> Paolo
>
> RFC->v1:
> - new patches 1-4, 6, 16
> - patches 9-10 have been merged already
>
> Paolo Bonzini (16):
>   configure: do not define or use the CPP variable
>   build: clean up ninja invocation
>   build: add a more generic way to specify make->ninja dependencies
>   build: do a full build before running TCG tests
>   configure, meson: move symlinking of ROMs to meson
>   tests/tcg: correct target CPU for sparc32
>   tests/tcg: merge configure.sh back into main configure script
>   configure: add missing cross compiler fallbacks
>   configure: handle host compiler in probe_target_compiler
>   configure: introduce --cross-prefix-*=
>   configure: include more binutils in tests/tcg makefile
>   configure: move symlink configuration earlier
>   configure: enable cross-compilation of s390-ccw
>   configure: enable cross-compilation of optionrom
>   configure: enable cross compilation of vof
>   configure: remove unused variables from config-host.mak
>
>  Makefile                     |   9 +-
>  configure                    | 605 ++++++++++++++++++++++++++++++-----
>  pc-bios/meson.build          |  18 +-
>  pc-bios/optionrom/Makefile   |   4 +-
>  pc-bios/s390-ccw/Makefile    |   9 +-
>  pc-bios/s390-ccw/netboot.mak |   2 +-
>  pc-bios/vof/Makefile         |  17 +-
>  scripts/mtest2make.py        |   8 +-
>  tests/Makefile.include       |   4 +-
>  tests/tcg/configure.sh       | 376 ----------------------
>  10 files changed, 570 insertions(+), 482 deletions(-)
>  delete mode 100755 tests/tcg/configure.sh


-- 
Alex Bennée