[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v7 08/14] migration: Export tls-[creds|hostname|authz] params to
From: |
Peter Xu |
Subject: |
[PATCH v7 08/14] migration: Export tls-[creds|hostname|authz] params to cmdline too |
Date: |
Tue, 24 May 2022 18:11:45 -0400 |
It's useful for specifying tls credentials all in the cmdline (along with
the -object tls-creds-*), especially for debugging purpose.
The trick here is we must remember to not free these fields again in the
finalize() function of migration object, otherwise it'll cause double-free.
The thing is when destroying an object, we'll first destroy the properties
that bound to the object, then the object itself. To be explicit, when
destroy the object in object_finalize() we have such sequence of
operations:
object_property_del_all(obj);
object_deinit(obj, ti);
So after this change the two fields are properly released already even
before reaching the finalize() function but in object_property_del_all(),
hence we don't need to free them anymore in finalize() or it's double-free.
This also fixes a trivial memory leak for tls-authz as we forgot to free it
before this patch.
Reviewed-by: Daniel P. Berrange <berrange@redhat.com>
Signed-off-by: Peter Xu <peterx@redhat.com>
---
migration/migration.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/migration/migration.c b/migration/migration.c
index d17f435d08..aa4185148c 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -4379,6 +4379,9 @@ static Property migration_properties[] = {
DEFAULT_MIGRATE_ANNOUNCE_STEP),
DEFINE_PROP_BOOL("x-postcopy-preempt-break-huge", MigrationState,
postcopy_preempt_break_huge, true),
+ DEFINE_PROP_STRING("tls-creds", MigrationState, parameters.tls_creds),
+ DEFINE_PROP_STRING("tls-hostname", MigrationState,
parameters.tls_hostname),
+ DEFINE_PROP_STRING("tls-authz", MigrationState, parameters.tls_authz),
/* Migration capabilities */
DEFINE_PROP_MIG_CAP("x-xbzrle", MIGRATION_CAPABILITY_XBZRLE),
@@ -4412,12 +4415,9 @@ static void migration_class_init(ObjectClass *klass,
void *data)
static void migration_instance_finalize(Object *obj)
{
MigrationState *ms = MIGRATION_OBJ(obj);
- MigrationParameters *params = &ms->parameters;
qemu_mutex_destroy(&ms->error_mutex);
qemu_mutex_destroy(&ms->qemu_file_lock);
- g_free(params->tls_hostname);
- g_free(params->tls_creds);
qemu_sem_destroy(&ms->wait_unplug_sem);
qemu_sem_destroy(&ms->rate_limit_sem);
qemu_sem_destroy(&ms->pause_sem);
--
2.32.0
- [PATCH v7 00/14] migration: Postcopy Preemption, Peter Xu, 2022/05/24
- [PATCH v7 01/14] migration: Add postcopy-preempt capability, Peter Xu, 2022/05/24
- [PATCH v7 02/14] migration: Postcopy preemption preparation on channel creation, Peter Xu, 2022/05/24
- [PATCH v7 03/14] migration: Postcopy preemption enablement, Peter Xu, 2022/05/24
- [PATCH v7 04/14] migration: Postcopy recover with preempt enabled, Peter Xu, 2022/05/24
- [PATCH v7 05/14] migration: Create the postcopy preempt channel asynchronously, Peter Xu, 2022/05/24
- [PATCH v7 07/14] migration: Add helpers to detect TLS capability, Peter Xu, 2022/05/24
- [PATCH v7 06/14] migration: Add property x-postcopy-preempt-break-huge, Peter Xu, 2022/05/24
- [PATCH v7 08/14] migration: Export tls-[creds|hostname|authz] params to cmdline too,
Peter Xu <=
- [PATCH v7 10/14] migration: Respect postcopy request order in preemption mode, Peter Xu, 2022/05/24
- [PATCH v7 11/14] tests: Move MigrateCommon upper, Peter Xu, 2022/05/24
- [PATCH v7 09/14] migration: Enable TLS for preempt channel, Peter Xu, 2022/05/24
- [PATCH v7 14/14] tests: Add postcopy preempt tests, Peter Xu, 2022/05/24
- [PATCH v7 13/14] tests: Add postcopy tls recovery migration test, Peter Xu, 2022/05/24
- [PATCH v7 12/14] tests: Add postcopy tls migration test, Peter Xu, 2022/05/24