[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 5/9] tests: add quiet-venv-pip macro
From: |
John Snow |
Subject: |
[PATCH 5/9] tests: add quiet-venv-pip macro |
Date: |
Wed, 25 May 2022 20:09:17 -0400 |
Factor out the "test venv pip" macro; rewrite the "check-venv" rule to
be a little more compact. Replace the "PIP" pseudo-command output with
"VENVPIP" to make it 1% more clear that we are talking about using pip
to install something into a venv.
Signed-off-by: John Snow <jsnow@redhat.com>
---
tests/Makefile.include | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/tests/Makefile.include b/tests/Makefile.include
index 839ffde876a..052d7f56e9a 100644
--- a/tests/Makefile.include
+++ b/tests/Makefile.include
@@ -104,13 +104,13 @@ else
AVOCADO_CMDLINE_TAGS=$(addprefix -t , $(AVOCADO_TAGS))
endif
+quiet-venv-pip = $(quiet-@)$(call quiet-command-run, \
+ $(TESTS_PYTHON) -m pip -q --disable-pip-version-check $1, \
+ "VENVPIP","$1")
+
$(TESTS_VENV_DIR): $(TESTS_VENV_REQ)
- $(call quiet-command, \
- $(PYTHON) -m venv $@, \
- VENV, $@)
- $(call quiet-command, \
- $(TESTS_PYTHON) -m pip -q --disable-pip-version-check install \
- -r $(TESTS_VENV_REQ), PIP, $(TESTS_VENV_REQ))
+ $(call quiet-command, $(PYTHON) -m venv $@, VENV, $@)
+ $(call quiet-venv-pip,install -r $(TESTS_VENV_REQ))
$(call quiet-command, touch $@)
$(TESTS_RESULTS_DIR):
--
2.34.1
- [PATCH 0/9] tests, python: prepare to expand usage of test venv, John Snow, 2022/05/25
- [PATCH 1/9] python: update for mypy 0.950, John Snow, 2022/05/25
- [PATCH 2/9] tests: add "TESTS_PYTHON" variable to Makefile, John Snow, 2022/05/25
- [PATCH 3/9] tests: use python3 as the python executable name, John Snow, 2022/05/25
- [PATCH 4/9] tests: silence pip upgrade warnings during venv creation, John Snow, 2022/05/25
- [PATCH 5/9] tests: add quiet-venv-pip macro,
John Snow <=
- Re: [PATCH 5/9] tests: add quiet-venv-pip macro, Paolo Bonzini, 2022/05/26
- [PATCH 6/9] tests: install "qemu" namespace package into venv, John Snow, 2022/05/25
- [PATCH 7/9] tests: use tests/venv to run basevm.py-based scripts, John Snow, 2022/05/25
- [PATCH 9/9] tests: run 'device-crash-test' from tests/venv, John Snow, 2022/05/25