[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 02/10] block: Change bdrv_{pread, pwrite, pwrite_sync}() p
From: |
Stefan Hajnoczi |
Subject: |
Re: [PATCH v3 02/10] block: Change bdrv_{pread, pwrite, pwrite_sync}() param order |
Date: |
Thu, 26 May 2022 09:41:11 +0100 |
On Thu, May 19, 2022 at 03:48:32PM +0100, Alberto Faria wrote:
> Swap 'buf' and 'bytes' around for consistency with
> bdrv_co_{pread,pwrite}(), and in preparation to implement these
> functions using generated_co_wrapper.
>
> Callers were updated using this Coccinelle script:
>
> @@ expression child, offset, buf, bytes, flags; @@
> - bdrv_pread(child, offset, buf, bytes, flags)
> + bdrv_pread(child, offset, bytes, buf, flags)
>
> @@ expression child, offset, buf, bytes, flags; @@
> - bdrv_pwrite(child, offset, buf, bytes, flags)
> + bdrv_pwrite(child, offset, bytes, buf, flags)
>
> @@ expression child, offset, buf, bytes, flags; @@
> - bdrv_pwrite_sync(child, offset, buf, bytes, flags)
> + bdrv_pwrite_sync(child, offset, bytes, buf, flags)
>
> Resulting overly-long lines were then fixed by hand.
>
> Signed-off-by: Alberto Faria <afaria@redhat.com>
> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> block/blklogwrites.c | 6 ++--
> block/bochs.c | 10 +++---
> block/cloop.c | 10 +++---
> block/crypto.c | 4 +--
> block/dmg.c | 26 +++++++--------
> block/io.c | 12 +++----
> block/parallels-ext.c | 6 ++--
> block/parallels.c | 10 +++---
> block/qcow.c | 34 +++++++++----------
> block/qcow2-bitmap.c | 14 ++++----
> block/qcow2-cache.c | 8 ++---
> block/qcow2-cluster.c | 22 ++++++-------
> block/qcow2-refcount.c | 56 +++++++++++++++++---------------
> block/qcow2-snapshot.c | 48 +++++++++++++--------------
> block/qcow2.c | 47 ++++++++++++++-------------
> block/qed.c | 8 ++---
> block/vdi.c | 14 ++++----
> block/vhdx-log.c | 18 +++++-----
> block/vhdx.c | 28 ++++++++--------
> block/vmdk.c | 50 ++++++++++++++--------------
> block/vpc.c | 22 ++++++-------
> block/vvfat.c | 10 +++---
> include/block/block-io.h | 10 +++---
> tests/unit/test-block-iothread.c | 8 ++---
> 24 files changed, 242 insertions(+), 239 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
signature.asc
Description: PGP signature
- [PATCH v3 00/10] Implement bdrv_{pread, pwrite, pwrite_sync, pwrite_zeroes}() using generated_co_wrapper, Alberto Faria, 2022/05/19
- [PATCH v3 02/10] block: Change bdrv_{pread, pwrite, pwrite_sync}() param order, Alberto Faria, 2022/05/19
- [PATCH v3 01/10] block: Add a 'flags' param to bdrv_{pread, pwrite, pwrite_sync}(), Alberto Faria, 2022/05/19
- [PATCH v3 05/10] block: Make bdrv_co_pwrite() take a const buffer, Alberto Faria, 2022/05/19
- [PATCH v3 03/10] block: Make bdrv_{pread, pwrite}() return 0 on success, Alberto Faria, 2022/05/19