[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 04/10] crypto: Make block callbacks return 0 on success
From: |
Stefan Hajnoczi |
Subject: |
Re: [PATCH v3 04/10] crypto: Make block callbacks return 0 on success |
Date: |
Thu, 26 May 2022 09:49:57 +0100 |
On Thu, May 19, 2022 at 03:48:34PM +0100, Alberto Faria wrote:
> They currently return the value of their headerlen/buflen parameter on
> success. Returning 0 instead makes it clear that short reads/writes are
> not possible.
>
> Signed-off-by: Alberto Faria <afaria@redhat.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> ---
> block/crypto.c | 52 +++++++++++++++++-----------------
> block/qcow2.c | 22 +++++++-------
> crypto/block-luks.c | 8 +++---
> crypto/block.c | 6 ++--
> include/crypto/block.h | 32 ++++++++++-----------
> tests/unit/test-crypto-block.c | 38 ++++++++++++-------------
> 6 files changed, 79 insertions(+), 79 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
signature.asc
Description: PGP signature
- [PATCH v3 06/10] block: Make 'bytes' param of bdrv_co_{pread, pwrite, preadv, pwritev}() an int64_t, (continued)
- [PATCH v3 06/10] block: Make 'bytes' param of bdrv_co_{pread, pwrite, preadv, pwritev}() an int64_t, Alberto Faria, 2022/05/19
- Re: [PATCH v3 06/10] block: Make 'bytes' param of bdrv_co_{pread,pwrite,preadv,pwritev}() an int64_t, Eric Blake, 2022/05/24
- Re: [PATCH v3 06/10] block: Make 'bytes' param of bdrv_co_{pread,pwrite,preadv,pwritev}() an int64_t, Stefan Hajnoczi, 2022/05/26
- [PATCH v3 08/10] block: Add bdrv_co_pwrite_sync(), Alberto Faria, 2022/05/19
- [PATCH v3 09/10] block: Use bdrv_co_pwrite_sync() when caller is coroutine_fn, Alberto Faria, 2022/05/19
- [PATCH v3 10/10] block/qcow2: Use bdrv_pwrite_sync() in qcow2_mark_dirty(), Alberto Faria, 2022/05/19
- [PATCH v3 04/10] crypto: Make block callbacks return 0 on success, Alberto Faria, 2022/05/19
- Re: [PATCH v3 04/10] crypto: Make block callbacks return 0 on success,
Stefan Hajnoczi <=