qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v1 05/33] tests/lcitool: fix up indentation to correct style


From: Daniel P . Berrangé
Subject: Re: [PATCH v1 05/33] tests/lcitool: fix up indentation to correct style
Date: Fri, 27 May 2022 16:43:21 +0100
User-agent: Mutt/2.2.1 (2022-02-19)

On Fri, May 27, 2022 at 04:35:35PM +0100, Alex Bennée wrote:
> 3 space indentation snuck into the initial commit. Clean it up before
> we let it get established. I've also:
> 
>   - removed unused os import
>   - added double lines between functions
>   - added some comments and grouped and sorted the generation stanzas
> 
> My lint tool is also recommending using f-strings but that requires
> python 3.6.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Cc: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  tests/lcitool/refresh | 134 ++++++++++++++++++++++++------------------
>  1 file changed, 76 insertions(+), 58 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




reply via email to

[Prev in Thread] Current Thread [Next in Thread]