[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v5 02/17] target/m68k: Switch over exception type in m68k_interru
From: |
Richard Henderson |
Subject: |
[PATCH v5 02/17] target/m68k: Switch over exception type in m68k_interrupt_all |
Date: |
Fri, 27 May 2022 09:47:52 -0700 |
Replace an if ladder with a switch for clarity.
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/m68k/op_helper.c | 49 +++++++++++++++++++++++++----------------
1 file changed, 30 insertions(+), 19 deletions(-)
diff --git a/target/m68k/op_helper.c b/target/m68k/op_helper.c
index d30f988ae0..2b94a6ec84 100644
--- a/target/m68k/op_helper.c
+++ b/target/m68k/op_helper.c
@@ -333,7 +333,8 @@ static void m68k_interrupt_all(CPUM68KState *env, int is_hw)
sp &= ~1;
}
- if (cs->exception_index == EXCP_ACCESS) {
+ switch (cs->exception_index) {
+ case EXCP_ACCESS:
if (env->mmu.fault) {
cpu_abort(cs, "DOUBLE MMU FAULT\n");
}
@@ -391,29 +392,39 @@ static void m68k_interrupt_all(CPUM68KState *env, int
is_hw)
"ssw: %08x ea: %08x sfc: %d dfc: %d\n",
env->mmu.ssw, env->mmu.ar, env->sfc, env->dfc);
}
- } else if (cs->exception_index == EXCP_ADDRESS) {
+ break;
+
+ case EXCP_ADDRESS:
do_stack_frame(env, &sp, 2, oldsr, 0, retaddr);
- } else if (cs->exception_index == EXCP_ILLEGAL ||
- cs->exception_index == EXCP_DIV0 ||
- cs->exception_index == EXCP_CHK ||
- cs->exception_index == EXCP_TRAPCC ||
- cs->exception_index == EXCP_TRACE) {
+ break;
+
+ case EXCP_ILLEGAL:
+ case EXCP_DIV0:
+ case EXCP_CHK:
+ case EXCP_TRAPCC:
+ case EXCP_TRACE:
/* FIXME: addr is not only env->pc */
do_stack_frame(env, &sp, 2, oldsr, env->pc, retaddr);
- } else if (is_hw && oldsr & SR_M &&
- cs->exception_index >= EXCP_SPURIOUS &&
- cs->exception_index <= EXCP_INT_LEVEL_7) {
- do_stack_frame(env, &sp, 0, oldsr, 0, retaddr);
- oldsr = sr;
- env->aregs[7] = sp;
- cpu_m68k_set_sr(env, sr &= ~SR_M);
- sp = env->aregs[7];
- if (!m68k_feature(env, M68K_FEATURE_UNALIGNED_DATA)) {
- sp &= ~1;
+ break;
+
+ case EXCP_SPURIOUS ... EXCP_INT_LEVEL_7:
+ if (is_hw && oldsr & SR_M) {
+ do_stack_frame(env, &sp, 0, oldsr, 0, retaddr);
+ oldsr = sr;
+ env->aregs[7] = sp;
+ cpu_m68k_set_sr(env, sr &= ~SR_M);
+ sp = env->aregs[7];
+ if (!m68k_feature(env, M68K_FEATURE_UNALIGNED_DATA)) {
+ sp &= ~1;
+ }
+ do_stack_frame(env, &sp, 1, oldsr, 0, retaddr);
+ break;
}
- do_stack_frame(env, &sp, 1, oldsr, 0, retaddr);
- } else {
+ /* fall through */
+
+ default:
do_stack_frame(env, &sp, 0, oldsr, 0, retaddr);
+ break;
}
env->aregs[7] = sp;
--
2.34.1
- [PATCH v5 04/17] linux-user/m68k: Handle EXCP_TRAP1 through EXCP_TRAP15, (continued)
- [PATCH v5 04/17] linux-user/m68k: Handle EXCP_TRAP1 through EXCP_TRAP15, Richard Henderson, 2022/05/27
- [PATCH v5 05/17] target/m68k: Remove retaddr in m68k_interrupt_all, Richard Henderson, 2022/05/27
- [PATCH v5 06/17] target/m68k: Fix address argument for EXCP_CHK, Richard Henderson, 2022/05/27
- [PATCH v5 07/17] target/m68k: Fix pc, c flag, and address argument for EXCP_DIV0, Richard Henderson, 2022/05/27
- [PATCH v5 10/17] target/m68k: Implement TRAPcc, Richard Henderson, 2022/05/27
- [PATCH v5 08/17] target/m68k: Fix address argument for EXCP_TRACE, Richard Henderson, 2022/05/27
- [PATCH v5 09/17] target/m68k: Fix stack frame for EXCP_ILLEGAL, Richard Henderson, 2022/05/27
- [PATCH v5 11/17] target/m68k: Implement TPF in terms of TRAPcc, Richard Henderson, 2022/05/27
- [PATCH v5 12/17] target/m68k: Implement TRAPV, Richard Henderson, 2022/05/27
- [PATCH v5 02/17] target/m68k: Switch over exception type in m68k_interrupt_all,
Richard Henderson <=
- [PATCH v5 13/17] target/m68k: Implement FTRAPcc, Richard Henderson, 2022/05/27
- [PATCH v5 15/17] linux-user/strace: Use is_error in print_syscall_err, Richard Henderson, 2022/05/27
- [PATCH v5 16/17] linux-user/strace: Adjust get_thread_area for m68k, Richard Henderson, 2022/05/27
- [PATCH v5 17/17] target/m68k: Mark helper_raise_exception as noreturn, Richard Henderson, 2022/05/27
- [PATCH v5 14/17] tests/tcg/m68k: Add trap.c, Richard Henderson, 2022/05/27
- Re: [PATCH v5 00/17] target/m68k: Conditional traps + trap cleanup, Laurent Vivier, 2022/05/28