[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 071/114] target/arm: Reject dup_i w/ shifted byte early
From: |
Richard Henderson |
Subject: |
[PATCH 071/114] target/arm: Reject dup_i w/ shifted byte early |
Date: |
Fri, 27 May 2022 11:18:24 -0700 |
Remove the unparsed extraction in trans_DUP_i,
which is intended to reject an 8-bit shift of
an 8-bit constant for 8-bit element.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/sve.decode | 5 ++++-
target/arm/translate-sve.c | 10 ++++++----
2 files changed, 10 insertions(+), 5 deletions(-)
diff --git a/target/arm/sve.decode b/target/arm/sve.decode
index 0388cce3bd..c02da0a082 100644
--- a/target/arm/sve.decode
+++ b/target/arm/sve.decode
@@ -787,7 +787,10 @@ WHILE_ptr 00100101 esz:2 1 rm:5 001 100 rn:5 rw:1
rd:4
FDUP 00100101 esz:2 111 00 1110 imm:8 rd:5
# SVE broadcast integer immediate (unpredicated)
-DUP_i 00100101 esz:2 111 00 011 . ........ rd:5 imm=%sh8_i8s
+{
+ INVALID 00100101 00 111 00 011 1 -------- -----
+ DUP_i 00100101 esz:2 111 00 011 . ........ rd:5 imm=%sh8_i8s
+}
# SVE integer add/subtract immediate (unpredicated)
ADD_zzi 00100101 .. 100 000 11 . ........ ..... @rdn_sh_i8u
diff --git a/target/arm/translate-sve.c b/target/arm/translate-sve.c
index c0781ecf60..14faef0564 100644
--- a/target/arm/translate-sve.c
+++ b/target/arm/translate-sve.c
@@ -403,6 +403,12 @@ const uint64_t pred_esz_masks[4] = {
0x1111111111111111ull, 0x0101010101010101ull
};
+static bool trans_INVALID(DisasContext *s, arg_INVALID *a)
+{
+ unallocated_encoding(s);
+ return true;
+}
+
/*
*** SVE Logical - Unpredicated Group
*/
@@ -3246,13 +3252,9 @@ static bool trans_FDUP(DisasContext *s, arg_FDUP *a)
static bool trans_DUP_i(DisasContext *s, arg_DUP_i *a)
{
- if (a->esz == 0 && extract32(s->insn, 13, 1)) {
- return false;
- }
if (sve_access_check(s)) {
unsigned vsz = vec_full_reg_size(s);
int dofs = vec_full_reg_offset(s, a->rd);
-
tcg_gen_gvec_dup_imm(a->esz, dofs, vsz, vsz, a->imm);
}
return true;
--
2.34.1
- [PATCH 078/114] target/arm: Use TRANS_FEAT for FMMLA, (continued)
- [PATCH 078/114] target/arm: Use TRANS_FEAT for FMMLA, Richard Henderson, 2022/05/27
- [PATCH 064/114] target/arm: Use TRANS_FEAT for do_last_general, Richard Henderson, 2022/05/27
- [PATCH 062/114] target/arm: Use TRANS_FEAT for do_clast_general, Richard Henderson, 2022/05/27
- [PATCH 061/114] target/arm: Use TRANS_FEAT for do_clast_fp, Richard Henderson, 2022/05/27
- [PATCH 072/114] target/arm: Reject add/sub w/ shifted byte early, Richard Henderson, 2022/05/27
- [PATCH 079/114] target/arm: Move sve check into gen_gvec_fn_ppp, Richard Henderson, 2022/05/27
- [PATCH 068/114] target/arm: Use TRANS_FEAT for do_ppzi_flags, Richard Henderson, 2022/05/27
- [PATCH 065/114] target/arm: Use TRANS_FEAT for SPLICE, Richard Henderson, 2022/05/27
- [PATCH 070/114] target/arm: Use TRANS_FEAT for MUL_zzi, Richard Henderson, 2022/05/27
- [PATCH 073/114] target/arm: Reject copy w/ shifted byte early, Richard Henderson, 2022/05/27
- [PATCH 071/114] target/arm: Reject dup_i w/ shifted byte early,
Richard Henderson <=
- [PATCH 075/114] target/arm: Use TRANS_FEAT for do_zzi_sat, Richard Henderson, 2022/05/27
- [PATCH 080/114] target/arm: Implement NOT (prediates) alias, Richard Henderson, 2022/05/27
- [PATCH 081/114] target/arm: Use TRANS_FEAT for SEL_zpzz, Richard Henderson, 2022/05/27
- [PATCH 086/114] target/arm: Use TRANS_FEAT for DO_FP3, Richard Henderson, 2022/05/27
- [PATCH 087/114] target/arm: Use TRANS_FEAT for FMUL_zzx, Richard Henderson, 2022/05/27
- [PATCH 088/114] target/arm: Use TRANS_FEAT for FTMAD, Richard Henderson, 2022/05/27
- [PATCH 092/114] target/arm: Expand frint_fns for MO_8, Richard Henderson, 2022/05/27
- [PATCH 082/114] target/arm: Use TRANS_FEAT for MOVPRFX, Richard Henderson, 2022/05/27
- [PATCH 083/114] target/arm: Use TRANS_FEAT for FMLA, Richard Henderson, 2022/05/27
- [PATCH 095/114] target/arm: Use TRANS_FEAT for do_frint_mode, Richard Henderson, 2022/05/27