[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] pci: fix overflow in printf string formatting
From: |
Claudio Fontana |
Subject: |
Re: [PATCH] pci: fix overflow in printf string formatting |
Date: |
Tue, 31 May 2022 12:12:29 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 |
On 5/31/22 11:55, Claudio Fontana wrote:
> On 5/31/22 11:47, Peter Maydell wrote:
>> On Tue, 31 May 2022 at 10:34, Claudio Fontana <cfontana@suse.de> wrote:
>>>
>>> Signed-off-by: Claudio Fontana <cfontana@suse.de>
>>
>> It would be helpful to note in the commit message how
>> bad the overflow is, in what situations it can happen,
>> and how it was detected.
>>
>> thanks
>> -- PMM
>
> Hi Peter,
>
> sorry I should have linked to this previous message by Dario:
>
> https://lists.gnu.org/archive/html/qemu-devel/2022-05/msg05518.html
>
> It was detected when building QEMU with FORTIFY_SOURCE=3.
>
> Thanks,
>
> Claudio
>
>
Will resend with more explanation in the commit message btw.