qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 05/10] cutils: add functions for IEC and SI prefixes


From: Paolo Bonzini
Subject: Re: [PATCH v5 05/10] cutils: add functions for IEC and SI prefixes
Date: Tue, 31 May 2022 12:28:08 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0

On 5/30/22 23:59, Philippe Mathieu-Daudé via wrote:

+    assert(exp10 % 3 == 0 && exp10 / 3 < ARRAY_SIZE(prefixes));

Can we add parenthesis to ease code review?
I'm not sure where... I thought about using two asserts too, but checking both % and / seems clear enough.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]