[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 15/15] target/arm: Export bfdotadd from vec_helper.c
From: |
Peter Maydell |
Subject: |
Re: [PATCH v3 15/15] target/arm: Export bfdotadd from vec_helper.c |
Date: |
Tue, 31 May 2022 13:35:06 +0100 |
On Fri, 27 May 2022 at 19:19, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> We will need this over in sme_helper.c.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/arm/vec_internal.h | 2 ++
> target/arm/vec_helper.c | 2 +-
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/target/arm/vec_internal.h b/target/arm/vec_internal.h
> index 43cff5ec7c..5e50c503aa 100644
> --- a/target/arm/vec_internal.h
> +++ b/target/arm/vec_internal.h
> @@ -230,4 +230,6 @@ uint64_t pmull_h(uint64_t op1, uint64_t op2);
> */
> uint64_t pmull_w(uint64_t op1, uint64_t op2);
>
> +float32 bfdotadd(float32 sum, uint32_t e1, uint32_t e2);
> +
A brief doc comment would be nice.
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
- Re: [PATCH v3 09/15] target/arm: Use el_is_in_host for sve_vqm1_for_el, (continued)
- [PATCH v3 10/15] target/arm: Split out load/store primitives to sve_ldst_internal.h, Richard Henderson, 2022/05/27
- [PATCH v3 12/15] target/arm: Move expand_pred_b to vec_internal.h, Richard Henderson, 2022/05/27
- [PATCH v3 05/15] target/arm: Use uint32_t instead of bitmap for sve vq's, Richard Henderson, 2022/05/27
- [PATCH v3 13/15] target/arm: Use expand_pred_b in mve_helper.c, Richard Henderson, 2022/05/27
- [PATCH v3 07/15] target/arm: Remove fp checks from sve_exception_el, Richard Henderson, 2022/05/27
- [PATCH v3 15/15] target/arm: Export bfdotadd from vec_helper.c, Richard Henderson, 2022/05/27
- Re: [PATCH v3 15/15] target/arm: Export bfdotadd from vec_helper.c,
Peter Maydell <=
- [PATCH v3 14/15] target/arm: Move expand_pred_h to vec_internal.h, Richard Henderson, 2022/05/27
- [PATCH v3 11/15] target/arm: Export sve contiguous ldst support functions, Richard Henderson, 2022/05/27
- [PATCH v3 04/15] target/arm: Merge aarch64_sve_zcr_get_valid_len into caller, Richard Henderson, 2022/05/27