qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH for-7.1] Revert "migration: Simplify unqueue_page()"


From: Thomas Huth
Subject: Re: [PATCH for-7.1] Revert "migration: Simplify unqueue_page()"
Date: Tue, 2 Aug 2022 10:58:36 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0

On 02/08/2022 10.47, Dr. David Alan Gilbert wrote:
* Thomas Huth (thuth@redhat.com) wrote:
This reverts commit cfd66f30fb0f735df06ff4220e5000290a43dad3.

The simplification of unqueue_page() introduced a bug that sometimes
breaks migration on s390x hosts. Seems like there are still pages here
that do not have their dirty bit set.

I don't think it's about 'not having their dirty bit set' - it's
perfectly fine to have the bits clear (which indicates the page has
already been sent to the destination, sometime inbetween the page request
being sent from the destination and it being unqueued).

Ok, could you maybe simply drop that sentence from the commit description when picking up the patch? Or shall I resend a v2?

 Thomas




reply via email to

[Prev in Thread] Current Thread [Next in Thread]