[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 15/22] tests/qtest: add a timeout for subprocess_run_one_test
From: |
Alex Bennée |
Subject: |
[PATCH v4 15/22] tests/qtest: add a timeout for subprocess_run_one_test |
Date: |
Tue, 2 Aug 2022 10:50:03 +0100 |
Hangs have been observed in the tests and currently we don't timeout
if a subprocess hangs. Rectify that.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
---
v3
- expand timeout to 180 at Thomas' suggestion
v4
- fix merge conflict with earlier patch
---
tests/qtest/qos-test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qtest/qos-test.c b/tests/qtest/qos-test.c
index 01a9393399..d958ef4be3 100644
--- a/tests/qtest/qos-test.c
+++ b/tests/qtest/qos-test.c
@@ -185,7 +185,7 @@ static void run_one_test(const void *arg)
static void subprocess_run_one_test(const void *arg)
{
const gchar *path = arg;
- g_test_trap_subprocess(path, 0,
+ g_test_trap_subprocess(path, 180 * G_USEC_PER_SEC,
G_TEST_SUBPROCESS_INHERIT_STDOUT |
G_TEST_SUBPROCESS_INHERIT_STDERR);
g_test_trap_assert_passed();
--
2.30.2
- [PATCH v4 02/22] hw/virtio: gracefully handle unset vhost_dev vdev, (continued)
- [PATCH v4 02/22] hw/virtio: gracefully handle unset vhost_dev vdev, Alex Bennée, 2022/08/02
- [PATCH v4 10/22] hw/virtio: move vm_running check to virtio_device_started, Alex Bennée, 2022/08/02
- [PATCH v4 04/22] hw/virtio: fix vhost_user_read tracepoint, Alex Bennée, 2022/08/02
- [PATCH v4 08/22] hw/virtio: log potentially buggy guest drivers, Alex Bennée, 2022/08/02
- [PATCH v4 13/22] hw/virtio: add vhost-user-gpio-pci boilerplate, Alex Bennée, 2022/08/02
- [PATCH v4 14/22] tests/qtest: pass stdout/stderr down to subtests, Alex Bennée, 2022/08/02
- [PATCH v4 16/22] tests/qtest: use qos_printf instead of g_test_message, Alex Bennée, 2022/08/02
- [PATCH v4 11/22] hw/virtio: move vhd->started check into helper and add FIXME, Alex Bennée, 2022/08/02
- [PATCH v4 19/22] tests/qtest: add assert to catch bad features, Alex Bennée, 2022/08/02
- [PATCH v4 15/22] tests/qtest: add a timeout for subprocess_run_one_test,
Alex Bennée <=
- [PATCH v4 20/22] tests/qtest: implement stub for VHOST_USER_GET_CONFIG, Alex Bennée, 2022/08/02
- [PATCH v4 21/22] tests/qtest: add a get_features op to vhost-user-test, Alex Bennée, 2022/08/02
- [PATCH v4 12/22] hw/virtio: add boilerplate for vhost-user-gpio device, Alex Bennée, 2022/08/02
- [PATCH v4 22/22] tests/qtest: enable tests for virtio-gpio, Alex Bennée, 2022/08/02