Re: [PATCH v1 1/1] migration: add remaining params->has_* = true in migration_instance_init()

[Dr. David Alan Gilbert]

* Leonardo Bras Soares Passos (leobras@redhat.com) wrote:
> Please include:
> 
> Fixes: 69ef1f36b0 ("migration: define 'tls-creds' and 'tls-hostname'
> migration parameters")
> Fixes: 1d58872a91 ("migration: do not wait for free thread")
> Fixes: d2f1d29b95 ("migration: add support for a "tls-authz" migration
> parameter")

Queued

> On Mon, Jul 25, 2022 at 10:02 PM Leonardo Bras <leobras@redhat.com> wrote:
> >
> > Some of params->has_* = true are missing in migration_instance_init, this
> > causes migrate_params_check() to skip some tests, allowing some
> > unsupported scenarios.
> >
> > Fix this by adding all missing params->has_* = true in
> > migration_instance_init().
> >
> > Signed-off-by: Leonardo Bras <leobras@redhat.com>
> > ---
> >  migration/migration.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/migration/migration.c b/migration/migration.c
> > index e03f698a3c..82fbe0cf55 100644
> > --- a/migration/migration.c
> > +++ b/migration/migration.c
> > @@ -4451,6 +4451,7 @@ static void migration_instance_init(Object *obj)
> >      /* Set has_* up only for parameter checks */
> >      params->has_compress_level = true;
> >      params->has_compress_threads = true;
> > +    params->has_compress_wait_thread = true;
> >      params->has_decompress_threads = true;
> >      params->has_throttle_trigger_threshold = true;
> >      params->has_cpu_throttle_initial = true;
> > @@ -4471,6 +4472,9 @@ static void migration_instance_init(Object *obj)
> >      params->has_announce_max = true;
> >      params->has_announce_rounds = true;
> >      params->has_announce_step = true;
> > +    params->has_tls_creds = true;
> > +    params->has_tls_hostname = true;
> > +    params->has_tls_authz = true;
> >
> >      qemu_sem_init(&ms->postcopy_pause_sem, 0);
> >      qemu_sem_init(&ms->postcopy_pause_rp_sem, 0);
> > --
> > 2.37.1
> >
> 
> 
-- 
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK