[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 1/5] migration: add remaining params->has_* = true in migration_in
From: |
Dr. David Alan Gilbert (git) |
Subject: |
[PULL 1/5] migration: add remaining params->has_* = true in migration_instance_init() |
Date: |
Tue, 2 Aug 2022 16:54:43 +0100 |
From: Leonardo Bras <leobras@redhat.com>
Some of params->has_* = true are missing in migration_instance_init, this
causes migrate_params_check() to skip some tests, allowing some
unsupported scenarios.
Fix this by adding all missing params->has_* = true in
migration_instance_init().
Fixes: 69ef1f36b0 ("migration: define 'tls-creds' and 'tls-hostname' migration
parameters")
Fixes: 1d58872a91 ("migration: do not wait for free thread")
Fixes: d2f1d29b95 ("migration: add support for a "tls-authz" migration
parameter")
Signed-off-by: Leonardo Bras <leobras@redhat.com>
Message-Id: <20220726010235.342927-1-leobras@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
migration/migration.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/migration/migration.c b/migration/migration.c
index e03f698a3c..82fbe0cf55 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -4451,6 +4451,7 @@ static void migration_instance_init(Object *obj)
/* Set has_* up only for parameter checks */
params->has_compress_level = true;
params->has_compress_threads = true;
+ params->has_compress_wait_thread = true;
params->has_decompress_threads = true;
params->has_throttle_trigger_threshold = true;
params->has_cpu_throttle_initial = true;
@@ -4471,6 +4472,9 @@ static void migration_instance_init(Object *obj)
params->has_announce_max = true;
params->has_announce_rounds = true;
params->has_announce_step = true;
+ params->has_tls_creds = true;
+ params->has_tls_hostname = true;
+ params->has_tls_authz = true;
qemu_sem_init(&ms->postcopy_pause_sem, 0);
qemu_sem_init(&ms->postcopy_pause_rp_sem, 0);
--
2.37.1
- [PULL 0/5] migration queue, Dr. David Alan Gilbert (git), 2022/08/02
- [PULL 1/5] migration: add remaining params->has_* = true in migration_instance_init(),
Dr. David Alan Gilbert (git) <=
- [PULL 2/5] Revert "migration: Simplify unqueue_page()", Dr. David Alan Gilbert (git), 2022/08/02
- [PULL 3/5] migration: Assert that migrate_multifd_compression() returns an in-range value, Dr. David Alan Gilbert (git), 2022/08/02
- [PULL 4/5] migration: Define BLK_MIG_BLOCK_SIZE as unsigned long long, Dr. David Alan Gilbert (git), 2022/08/02
- [PULL 5/5] virtiofsd: Disable killpriv_v2 by default, Dr. David Alan Gilbert (git), 2022/08/02
- Re: [PULL 0/5] migration queue, Richard Henderson, 2022/08/02