Re: [PATCH] net/colo.c: Fix the pointer issuse reported by Coverity.

[Peter Maydell]

On Fri, 5 Aug 2022 at 06:56, Zhang, Chen <chen.zhang@intel.com> wrote:
>
>
>
> > -----Original Message-----
> > From: Jason Wang <jasowang@redhat.com>
> > I wonder under which case we can see data == NULL?
> >
> > AFAIK, data is either dup via packet_new() or assigned to a pointer to the 
> > buf
> > in packet_new_nocopy().
>
> Yes, you are right. I just checked it for hint of bugs.
> Do you think no need to do it?

If you think it is a "should never happen unless QEMU is buggy" case, then
 assert(data).

thanks
-- PMM