Re: [PATCH 0/1] Update vfio-user module to the latest

[Thomas Huth]

On 05/08/2022 10.55, Michael S. Tsirkin wrote:
> On Fri, Aug 05, 2022 at 09:21:07AM +0200, Thomas Huth wrote:
> > On 02/08/2022 12.00, Zhang, Chen wrote:
> > > > -----Original Message-----
> > > > From: Qemu-devel <qemu-devel-
> > > > bounces+chen.zhang=intel.com@nongnu.org> On Behalf Of Jagannathan
> > > > Raman
> > > > Sent: Tuesday, August 2, 2022 9:24 AM
> > > > To: qemu-devel@nongnu.org
> > > > Cc: stefanha@gmail.com; berrange@redhat.com
> > > > Subject: [PATCH 0/1] Update vfio-user module to the latest
> > > >
> > > > Hi,
> > > >
> > > > This patch updates the libvfio-user submodule to the latest.
> > >
> > > Just a rough idea, why not depends on linux distribution for the 
> > > libvfio-user.so?
> > > It looks no libvfio-user packet in distribution's repo.
> > >
> > > Hi Thomas/Daniel:
> > >
> > > For the RFC QEMU user space eBPF support,
> > > https://lore.kernel.org/all/20220617073630.535914-6-chen.zhang@intel.com/T/
> > > Maybe introduce the libubpf.so as a subproject like libvfio-user.so is more 
> > > appropriate?
> >
> > Fair comment. I never noticed them before, but why do we have those
> > submodules in the subprojects/ folder (libvduse, libvfio-user and
> > libvhost-user)?
>
> I don't think they are submodules are they?

Drat, my bad! It's only libvfio-user that is a submodule. Never mind the 
other two.

> > ... I don't think it's the job of QEMU to ship libraries
> > that a user might want to use for a certain feature, so could we please
> > remove those submodules again?
>
> Why not?  Fundamentally I don't see why would libvhost-user be less
> important to users than e.g. qemu-img or qemu-bridge-helper. There's no
> rule saying we can only ship a single binary.

If libvhost-user does not have another home, then it's fine to have it here, 
I guess, but libvfio-user should rather be packaged as a proper library by 
the distros instead if it has a different upstream home.

 Thomas