Re: [PATCH v8 07/12] vdpa: add net_vhost_vdpa_cvq_info NetClientInfo

[Jason Wang]

On Wed, Aug 10, 2022 at 1:39 AM Eugenio Pérez <eperezma@redhat.com> wrote:
>
> Next patches will add a new info callback to restore NIC status through
> CVQ. Since only the CVQ vhost device is needed, create it with a new
> NetClientInfo.
>
> Signed-off-by: Eugenio Pérez <eperezma@redhat.com>

Acked-by: Jason Wang <jasowang@redhat.com>

> ---
> v5: Create a new NetClientInfo instead of reusing the dataplane one.
> ---
>  net/vhost-vdpa.c | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c
> index ac1810723c..55e8a39a56 100644
> --- a/net/vhost-vdpa.c
> +++ b/net/vhost-vdpa.c
> @@ -334,6 +334,16 @@ static bool vhost_vdpa_net_cvq_map_elem(VhostVDPAState 
> *s,
>      return true;
>  }
>
> +static NetClientInfo net_vhost_vdpa_cvq_info = {
> +    .type = NET_CLIENT_DRIVER_VHOST_VDPA,
> +    .size = sizeof(VhostVDPAState),
> +    .receive = vhost_vdpa_receive,
> +    .cleanup = vhost_vdpa_cleanup,
> +    .has_vnet_hdr = vhost_vdpa_has_vnet_hdr,
> +    .has_ufo = vhost_vdpa_has_ufo,
> +    .check_peer_type = vhost_vdpa_check_peer_type,
> +};
> +
>  /**
>   * Do not forward commands not supported by SVQ. Otherwise, the device could
>   * accept it and qemu would not know how to update the device model.
> @@ -475,7 +485,7 @@ static NetClientState *net_vhost_vdpa_init(NetClientState 
> *peer,
>          nc = qemu_new_net_client(&net_vhost_vdpa_info, peer, device,
>                                   name);
>      } else {
> -        nc = qemu_new_net_control_client(&net_vhost_vdpa_info, peer,
> +        nc = qemu_new_net_control_client(&net_vhost_vdpa_cvq_info, peer,
>                                           device, name);
>      }
>      snprintf(nc->info_str, sizeof(nc->info_str), TYPE_VHOST_VDPA);
> --
> 2.31.1
>