Re: [PATCH 22/62] target/arm: Add secure parameter to get_phys_addr_pmsav8

[Richard Henderson]

On 8/10/22 06:16, Alex Bennée wrote:
> Richard Henderson <richard.henderson@linaro.org> writes:
>
> > Remove the use of regime_is_secure from get_phys_addr_pmsav8.
> > Since we already had a local variable named secure, use that.
> >
> > Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> > ---
> >   target/arm/ptw.c | 5 ++---
> >   1 file changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git a/target/arm/ptw.c b/target/arm/ptw.c
> > index d424dec729..f7892a0c48 100644
> > --- a/target/arm/ptw.c
> > +++ b/target/arm/ptw.c
> > @@ -1960,10 +1960,9 @@ void v8m_security_lookup(CPUARMState *env, uint32_t 
> > address,
> >   
> >   static bool get_phys_addr_pmsav8(CPUARMState *env, uint32_t address,
> >                                    MMUAccessType access_type, ARMMMUIdx mmu_idx,
> > -                                 GetPhysAddrResult *result,
> > +                                 bool secure, GetPhysAddrResult
> >   *result,
>
> NIT: why not use is_secure like all the other functions (and reformat
> the commit subject to match too).

It's right there in the commit message -- there was an existing local variable.


r~

> Otherwise:
>
> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>