RE: [PATCH v3 1/2] Update AVX512 support for xbzrle_encode_buffer function

[Xu, Ling1]

Hi, Richard,
      Thanks for your nice comments! Your suggestions are very helpful. We have 
revised code in ram.c according to your comments. As for "unroll residual from 
main loop" problem in algorithm, we will fix this later. Thanks for your time 
and patience~

Best Regards,
Ling

-----Original Message-----
From: Richard Henderson <richard.henderson@linaro.org> 
Sent: Wednesday, August 10, 2022 2:25 AM
To: Xu, Ling1 <ling1.xu@intel.com>; quintela@redhat.com
Cc: qemu-devel@nongnu.org; dgilbert@redhat.com; Zhao, Zhou 
<zhou.zhao@intel.com>; Jin, Jun I <jun.i.jin@intel.com>
Subject: Re: [PATCH v3 1/2] Update AVX512 support for xbzrle_encode_buffer 
function

On 8/9/22 00:51, Xu, Ling1 wrote:
> Hi, Juan,
>        Thanks for your advice. We have revised our code including: 1) change 
> "IS_CPU_SUPPORT_AVX512BW" to "is_cpu_support_avx512bw" to indicate that 
> variable isn't global variable;

You can remove this variable entirely...

> 2) use a function pointer to simplify code in ram.c;

... because it's redundant with the function pointer.


r~