[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] hw/arm/virt-acpi-build: Present the GICR structure properly
|
From: |
Peter Maydell |
|
Subject: |
Re: [PATCH] hw/arm/virt-acpi-build: Present the GICR structure properly for GICv4 |
|
Date: |
Fri, 12 Aug 2022 11:25:11 +0100 |
On Fri, 12 Aug 2022 at 03:20, Zenghui Yu <yuzenghui@huawei.com> wrote:
>
> With the introduction of the new TCG GICv4, build_madt() is badly broken
> as we do not present any GIC Redistributor structure in MADT for GICv4
> guests, so that they have no idea about where the Redistributor
> register frames are. This fixes a Linux guest crash at boot time with
> ACPI enabled and '-machine gic-version=4'.
>
> While at it, let's convert the remaining hard coded gic_version into
> enumeration VIRT_GIC_VERSION_2 for consistency.
>
> Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
Oops, I missed the ACPI side of things when I added GICv4
support :-(
Crash-on-boot seems like a bug worth fixing for rc3...
Applied to target-arm.next, thanks.
-- PMM