Re: [PATCH 03/20] disas/nanomips: Delete NMD class fields

[Richard Henderson]

On 8/15/22 02:26, Milica Lazarevic wrote:
> Class fields have been replaced with the public static variables.
> Therefore, there is no more need for a constructor. The main goal is to
> remove NMD class completely.
>
> Signed-off-by: Milica Lazarevic <milica.lazarevic@syrmia.com>
> ---
>   disas/nanomips.cpp | 6 +++++-
>   disas/nanomips.h   | 9 ---------
>   2 files changed, 5 insertions(+), 10 deletions(-)
>
> diff --git a/disas/nanomips.cpp b/disas/nanomips.cpp
> index 00e489fd59..2cbaa122ae 100644
> --- a/disas/nanomips.cpp
> +++ b/disas/nanomips.cpp
> @@ -40,6 +40,8 @@
>   
>   #define IMGASSERTONCE(test)
>   
> +static img_address           m_pc;
> +static TABLE_ATTRIBUTE_TYPE   m_requested_instruction_categories;

This is not a viable solution, as it is not thread-safe.  You need to keep a struct and 
add it as an explicit argument where required.


r~