qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 19/20] disas/nanomips: Add modifier static


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH 19/20] disas/nanomips: Add modifier static
Date: Tue, 16 Aug 2022 02:22:47 +0200
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.12.0

On 15/8/22 09:26, Milica Lazarevic wrote:
Modifier static has been added to the remaining functions that shouldn't
be used outside of the nanomips disassembler.

Signed-off-by: Milica Lazarevic <milica.lazarevic@syrmia.com>
---
  disas/nanomips.cpp | 8 ++++----
  1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/disas/nanomips.cpp b/disas/nanomips.cpp
index e7d6bffe84..6cb527d1f7 100644
--- a/disas/nanomips.cpp
+++ b/disas/nanomips.cpp
@@ -114,13 +114,13 @@ static const char *to_string(img_address a)
  }
-uint64 extract_bits(uint64 data, uint32 bit_offset, uint32 bit_size)
+static uint64 extract_bits(uint64 data, uint32 bit_offset, uint32 bit_size)
  {
      return (data << (64 - (bit_size + bit_offset))) >> (64 - bit_size);
  }
-int64 sign_extend(int64 data, int msb)
+static int64 sign_extend(int64 data, int msb)
  {
      uint64 shift = 63 - msb;
      return (data << shift) >> shift;
@@ -463,7 +463,7 @@ static uint64 encode_shift3_from_shift(uint64 d)
/* special value for load literal */
-int64 encode_eu_from_s_li16(uint64 d)
+static int64 encode_eu_from_s_li16(uint64 d)
  {
      IMGASSERTONCE(d < 128);
      return d == 127 ? -1 : (int64)d;
@@ -22780,7 +22780,7 @@ static struct Pool MAJOR[2] = {
  };
-int nanomips_dis(char *buf,
+static int nanomips_dis(char *buf,
                   unsigned address,
                   unsigned short one,
                   unsigned short two,

This seems to belong to patch #4 "Remove helper methods from class",
shouldn't this be squashed there?



reply via email to

[Prev in Thread] Current Thread [Next in Thread]