Re: [PATCH v2 00/31] QOMify PPC4xx devices and minor clean ups

[BALATON Zoltan]

On Thu, 18 Aug 2022, Cédric Le Goater wrote:
> Daniel,
>
> On 8/17/22 17:08, BALATON Zoltan wrote:
> > Hello,
> >
> > This is based on gitlab.com/danielhb/qemu/tree/ppc-7.2
> >
> > This series contains the rest of Cédric's OOM'ify patches modified
> > according my review comments and some other clean ups I've noticed
> > along the way.
>
> I think patches 01-24 are good for merge.

When merging note the v3 for patch 21.

> > v2 now also includes the sdram changes after some clean up to simplify
> > it. This should now be the same state as Cédric's series. I shall
> > continue with the ppc440_sdram DDR2 controller model used by the
> > sam460ex but that needs a bit more chnages. But it is independent of
> > this series so this can be merged now and I can follow up later in a
> > separate series.
>
> I will take a look at the SDRAM changes later.

OK, I'll probably resend these starting from patch 25 with some small 
chnages: the v3 I've sent for the last patch and one I noticed in patch 30 
which is just making ppc4xx_sdram_bank_sizes array local to 
ppc4xx_sdram_ddr_realize() as it's not used anywhere else and this avoids 
clash with similar array when I move the sam460 version here. Other than 
these These patches should be stable I'll just plan to add additional 
patches to handle the sam460ex SDRAM controller as well. If you have any 
comments to the current patches I can incorporate those in this new 
series.

Regards,
BALATON Zoltan