qemu-devel
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] block: use bdrv_is_sg() helper instead of raw bs->sg rea

From: Vladimir Sementsov-Ogievskiy
Subject: Re: [PATCH 1/2] block: use bdrv_is_sg() helper instead of raw bs->sg reading
Date: Fri, 19 Aug 2022 18:51:11 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 
On 8/17/22 11:37, Denis V. Lunev wrote:

I believe that if the helper exists, it must be used always for reading
of the value. It breaks expectations in the other case.

Signed-off-by: Denis V. Lunev<den@openvz.org>
CC: Kevin Wolf<kwolf@redhat.com>
CC: Hanna Reitz<hreitz@redhat.com>
CC: Stefan Hajnoczi<stefanha@redhat.com>
CC: Fam Zheng<fam@euphon.net>
CC: Ronnie Sahlberg<ronniesahlberg@gmail.com>
CC: Paolo Bonzini<pbonzini@redhat.com>
CC: Peter Lieven<pl@kamp.de>
CC: Vladimir Sementsov-Ogievskiy<vsementsov@yandex-team.ru>


Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>

--
Best regards,
Vladimir
reply via email to
[Prev in Thread] Current Thread [Next in Thread]