[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 4/7] vdpa: Remove SVQ vring from iova_tree at shutdown
From: |
Eugenio Pérez |
Subject: |
[PATCH 4/7] vdpa: Remove SVQ vring from iova_tree at shutdown |
Date: |
Fri, 19 Aug 2022 18:53:54 +0200 |
Although the device will be reset before usage, the right thing to do is
to clean it.
Reported-by: Lei Yang <leiyang@redhat.com>
Fixes: 34e3c94eda ("vdpa: Add custom IOTLB translations to SVQ")
Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
---
hw/virtio/vhost-vdpa.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c
index 7e28d2f674..943799c17c 100644
--- a/hw/virtio/vhost-vdpa.c
+++ b/hw/virtio/vhost-vdpa.c
@@ -898,7 +898,12 @@ static bool vhost_vdpa_svq_unmap_ring(struct vhost_vdpa *v,
size = ROUND_UP(result->size, qemu_real_host_page_size());
r = vhost_vdpa_dma_unmap(v, result->iova, size);
- return r == 0;
+ if (unlikely(r < 0)) {
+ return false;
+ }
+
+ vhost_iova_tree_remove(v->iova_tree, result);
+ return 0;
}
static bool vhost_vdpa_svq_unmap_rings(struct vhost_dev *dev,
--
2.31.1
- [PATCH 5/7] vdpa: Make SVQ vring unmapping return void, (continued)
- [PATCH 5/7] vdpa: Make SVQ vring unmapping return void, Eugenio Pérez, 2022/08/19
- [PATCH 7/7] vdpa: Use ring hwaddr at vhost_vdpa_svq_unmap_ring, Eugenio Pérez, 2022/08/19
- [PATCH 6/7] vhost: Always store new kick fd on vhost_svq_set_svq_kick_fd, Eugenio Pérez, 2022/08/19
- [PATCH 3/7] util: make a copy of iova_tree_remove_parameter, Eugenio Pérez, 2022/08/19
- [PATCH 1/7] vdpa: Skip the maps not in the iova tree, Eugenio Pérez, 2022/08/19
- [PATCH 4/7] vdpa: Remove SVQ vring from iova_tree at shutdown,
Eugenio Pérez <=