Re: [PATCH 2/4] tests/migration/aarch64: Speed up the aarch64 migration test

[Daniel P . Berrangé]

On Fri, Aug 19, 2022 at 07:38:00AM +0200, Thomas Huth wrote:
> The migration tests spend a lot of time waiting for a sign of live
> of the guest on the serial console. The aarch64 migration code only
> outputs "B"s every couple of seconds (at least it takes more than 4
> seconds between each characeter on my x86 laptop). There are a lot
> of migration tests, and if each test that checks for a successful
> migration waits for these characters before and after migration, the
> wait time sums up to multiple minutes! Let's use a shorter delay to
> speed things up.
> 
> While we're at it, also remove a superfluous masking with 0xff - we're
> reading and storing bytes, so the upper bits of the register do not
> matter anyway.
> 
> With these changes, the test runs twice as fast on my laptop, decreasing
> the total run time from approx. 8 minutes to only 4 minutes!
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  tests/migration/aarch64/a-b-kernel.h | 10 +++++-----
>  tests/migration/aarch64/a-b-kernel.S |  3 +--
>  2 files changed, 6 insertions(+), 7 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|