[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v1 2/6] tests/qtest/migration-test: Only wait for serial output w
From: |
Alex Bennée |
Subject: |
[PATCH v1 2/6] tests/qtest/migration-test: Only wait for serial output where migration succeeds |
Date: |
Mon, 22 Aug 2022 17:56:04 +0100 |
From: Thomas Huth <thuth@redhat.com>
Waiting for the serial output can take a couple of seconds - and since
we're doing a lot of migration tests, this time easily sums up to
multiple minutes. But if a test is supposed to fail, it does not make
much sense to wait for the source to be in the right state first, so
we can skip the waiting here. This way we can speed up all tests where
the migration is supposed to fail. In the gitlab-CI gprov-gcov test,
each of the migration-tests now run two minutes faster!
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20220819053802.296584-2-thuth@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
tests/qtest/migration-test.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
index 520a5f917c..7be321b62d 100644
--- a/tests/qtest/migration-test.c
+++ b/tests/qtest/migration-test.c
@@ -1307,7 +1307,9 @@ static void test_precopy_common(MigrateCommon *args)
}
/* Wait for the first serial output from the source */
- wait_for_serial("src_serial");
+ if (args->result == MIG_TEST_SUCCEED) {
+ wait_for_serial("src_serial");
+ }
if (!args->connect_uri) {
g_autofree char *local_connect_uri =
--
2.30.2
- [PATCH for 7.1 v1 0/6] testing fixes and doc tweak pre-PR, Alex Bennée, 2022/08/22
- [PATCH v1 2/6] tests/qtest/migration-test: Only wait for serial output where migration succeeds,
Alex Bennée <=
- [PATCH v1 1/6] tests/avocado: push default timeout to QemuBaseTest, Alex Bennée, 2022/08/22
- [PATCH v1 4/6] tests/migration/i386: Speed up the i386 migration test (when using TCG), Alex Bennée, 2022/08/22
- [PATCH v1 5/6] tests/qtest/migration-test: Remove duplicated test_postcopy from the test plan, Alex Bennée, 2022/08/22
- [PATCH v1 3/6] tests/migration/aarch64: Speed up the aarch64 migration test, Alex Bennée, 2022/08/22
- [PATCH v1 6/6] qemu-options: try and clarify preferred block semantics, Alex Bennée, 2022/08/22