qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PULL 1/6] tests/avocado: push default timeout to QemuBaseTest


From: Thomas Huth
Subject: Re: [PULL 1/6] tests/avocado: push default timeout to QemuBaseTest
Date: Wed, 24 Aug 2022 11:42:50 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0

On 24/08/2022 11.19, Alex Bennée wrote:

Richard Henderson <richard.henderson@linaro.org> writes:

On 8/23/22 08:25, Alex Bennée wrote:
All of the QEMU tests eventually end up derrived from this class. Move
the default timeout from LinuxTest to ensure we catch them all. As 15
minutes is fairly excessive we drop the default down to 2 minutes
which is a more reasonable target for tests to aim for.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20220822165608.2980552-2-alex.bennee@linaro.org>
diff --git a/tests/avocado/avocado_qemu/__init__.py
b/tests/avocado/avocado_qemu/__init__.py
index ed4853c805..0efd2bd212 100644
--- a/tests/avocado/avocado_qemu/__init__.py
+++ b/tests/avocado/avocado_qemu/__init__.py
@@ -227,6 +227,10 @@ def exec_command_and_wait_for_pattern(test, command,
       _console_interaction(test, success_message, failure_message, command + 
'\r')
     class QemuBaseTest(avocado.Test):
+
+    # default timeout for all tests, can be overridden
+    timeout = 120
+
       def _get_unique_tag_val(self, tag_name):
           """
           Gets a tag value, if unique for a key
@@ -512,7 +516,6 @@ class LinuxTest(LinuxSSHMixIn, QemuSystemTest):
       to start with than the more vanilla `QemuSystemTest` class.
       """
   -    timeout = 900
       distro = None
       username = 'root'
       password = 'password'

Bah.

https://gitlab.com/qemu-project/qemu/-/jobs/2923804714


Hmm weird - the avocado CFI job doesn't even appear on my CI list (even
with push-ci-now).

You likely have to set QEMU_CI_AVOCADO_TESTING in your gitlab settings, see docs/devel/ci-jobs.rst.inc.

I think we really have to rework the way we run (or rather not run) the avocado tests - since with the current default behavior, they'll be ignored by most people by default.

 Thomas





reply via email to

[Prev in Thread] Current Thread [Next in Thread]