Re: [PATCH 02/17] target/i386: introduce insn_get_addr

[Richard Henderson]

On 8/24/22 10:31, Paolo Bonzini wrote:
> The "O" operand type in the Intel SDM needs to load an 8- to 64-bit
> unsigned value, while insn_get is limited to 32 bits.  Extract the code
> out of disas_insn and into a separate function.
>
> Signed-off-by: Paolo Bonzini<pbonzini@redhat.com>
> ---
>   target/i386/tcg/decode-old.c.inc | 11 +----------
>   target/i386/tcg/translate.c      | 25 +++++++++++++++++++++++++
>   2 files changed, 26 insertions(+), 10 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

Especially if you wanted to sort this before the decode-old.c.inc split.


r~