[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] dump: fix kdump to work over non-aligned blocks
|
From: |
David Hildenbrand |
|
Subject: |
Re: [PATCH 2/2] dump: fix kdump to work over non-aligned blocks |
|
Date: |
Fri, 26 Aug 2022 12:10:29 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 |
On 26.08.22 12:07, David Hildenbrand wrote:
> On 26.08.22 12:02, Marc-André Lureau wrote:
>> Hi
>>
>>
>> On Fri, Aug 26, 2022 at 2:01 PM David Hildenbrand <david@redhat.com
>> <mailto:david@redhat.com>> wrote:
>>
>> On 25.08.22 15:21, marcandre.lureau@redhat.com
>> <mailto:marcandre.lureau@redhat.com> wrote:
>> > From: Marc-André Lureau <marcandre.lureau@redhat.com
>> <mailto:marcandre.lureau@redhat.com>>
>> >
>> > Rewrite get_next_page() to work over non-aligned blocks. When it
>> > encounters non aligned addresses, it will allocate a zero-page and try
>> > to fill it.
>>
>> Could we simplify by using one global helper page (or caller provided
>> page) and avoiding the allocation/freeing?
>>
>>
>> I don't think that makes a big difference, but certainly doable.
>
> If we're using one central page, I guess we'd have to pass "flag_sync =
> true" to write_cache() in case that page is used. Or we simply specify
> on the single global page in there and force a sync. Changes would be
> limited to get_next_page() and write_cache() then.
I might be wrong. I think we might not have to touch write_cache() at
all -- it will copy the data into the DataCache buffer.
--
Thanks,
David / dhildenb