[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 09/51] fsdev/virtfs-proxy-helper: Use g_mkdir_with_parents()
From: |
Christian Schoenebeck |
Subject: |
Re: [PATCH 09/51] fsdev/virtfs-proxy-helper: Use g_mkdir_with_parents() |
Date: |
Fri, 26 Aug 2022 15:27:16 +0200 |
On Freitag, 26. August 2022 14:38:27 CEST Bin Meng wrote:
> On Fri, Aug 26, 2022 at 7:16 PM Christian Schoenebeck
>
> <qemu_oss@crudebyte.com> wrote:
> > On Freitag, 26. August 2022 12:30:20 CEST Bin Meng wrote:
> > > On Fri, Aug 26, 2022 at 6:09 PM Christian Schoenebeck
> > >
> > > <qemu_oss@crudebyte.com> wrote:
> > > > On Mittwoch, 24. August 2022 11:39:47 CEST Bin Meng wrote:
> > > > > From: Bin Meng <bin.meng@windriver.com>
> > > > >
> > > > > Use the same g_mkdir_with_parents() call to create a directory on
> > > > > all platforms.
> > > >
> > > > The same would be g_mkdir(), not g_mkdir_with_parents(), so please use
> > > > that
> > > > instead.
> > >
> > > No, g_mkdir() is a deprecated API.
> >
> > Where did you got that from? AFAICS g_mkdir() does not seem to be
> > deprecated:
> > https://gitlab.gnome.org/GNOME/glib/-/blob/main/glib/gstdio.c#L1201
> > https://gitlab.gnome.org/GNOME/glib/-/blob/main/glib/gstdio.h#L131>
> > > Search result (https://docs.gtk.org/glib/?q=mkdir) shows only
> > > g_mkdir_with_parents().
> >
> > Yeah, but that does not say that it was deprecated.
>
> Umm, correct. However I don't remember where I got the statement that
> it was deprecated.
>
> Maybe I was misled by the doc. Do you know why does the doc not
> document g_mkdir()?
Maybe gtk-doc does not define G_STDIO_WRAP_ON_UNIX?
Other functions like g_chmod() are missing in the generated docs as well,
whereas g_access() et al. are there, those are declared in both conditions.
> Regards,
> Bin
- Re: [PATCH 04/51] semihosting/arm-compat-semi: Avoid using hardcoded /tmp, (continued)
[PATCH 07/51] tests: Avoid using hardcoded /tmp in test cases, Bin Meng, 2022/08/24
[PATCH 10/51] hw/usb: dev-mtp: Use g_mkdir_with_parents(), Bin Meng, 2022/08/24
[PATCH 11/51] qga/commands-posix-ssh: Use g_mkdir_with_parents(), Bin Meng, 2022/08/24
[PATCH 12/51] tests: Use g_mkdir_with_parents(), Bin Meng, 2022/08/24