[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH for-7.2 v4 17/21] device_tree.c: support remaining FDT prop types
From: |
Daniel Henrique Barboza |
Subject: |
[PATCH for-7.2 v4 17/21] device_tree.c: support remaining FDT prop types |
Date: |
Fri, 26 Aug 2022 11:11:46 -0300 |
When printing a blob with 'dtc' using the '-O dts' option there are 3
distinct data types being printed: strings, arrays of uint32s and
regular byte arrays.
Previous patch added support to print strings. Let's add the remaining
formats. We want to resemble the format that 'dtc -O dts' uses, so every
uint32 array uses angle brackets (<>), and regular byte array uses square
brackets ([]). For properties that has no values we keep printing just
its name.
The /chosen FDT node from the pSeris machine gives an example of all
property types 'info fdt' is now able to display:
(qemu) info fdt /chosen
chosen {
ibm,architecture-vec-5 = [00 00];
rng-seed = <0x9cf5071b 0xf8804213 0xbe797764 0xad3d955 0xe0c9637 0x1f99c61e
0xe9243741 0xe800f17d>;
ibm,arch-vec-5-platform-support = <0x178018c0 0x19001a40>;
linux,pci-probe-only = <0x0>;
stdout-path = "/vdevice/vty@71000000";
linux,stdout-path = "/vdevice/vty@71000000";
qemu,graphic-depth = <0x20>;
qemu,graphic-height = <0x258>;
qemu,graphic-width = <0x320>;
}
Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
---
softmmu/device_tree.c | 57 ++++++++++++++++++++++++++++++++++++++++++-
1 file changed, 56 insertions(+), 1 deletion(-)
diff --git a/softmmu/device_tree.c b/softmmu/device_tree.c
index 3e38d9ddad..a770c6c1cc 100644
--- a/softmmu/device_tree.c
+++ b/softmmu/device_tree.c
@@ -720,6 +720,52 @@ static void fdt_prop_format_string_array(GString *buf,
g_string_append_printf(buf, ";\n");
}
+static bool fdt_prop_is_uint32_array(int size)
+{
+ return size % 4 == 0;
+}
+
+static void fdt_prop_format_uint32_array(GString *buf,
+ const char *propname,
+ const void *data,
+ int prop_size, int padding)
+{
+ const fdt32_t *array = data;
+ int array_len = prop_size / 4;
+ int i;
+
+ g_string_append_printf(buf, "%*s%s = <", padding, "", propname);
+
+ for (i = 0; i < array_len; i++) {
+ g_string_append_printf(buf, "0x%" PRIx32, fdt32_to_cpu(array[i]));
+
+ if (i < array_len - 1) {
+ g_string_append_printf(buf, " ");
+ }
+ }
+
+ g_string_append_printf(buf, ">;\n");
+}
+
+static void fdt_prop_format_val(GString *buf, const char *propname,
+ const void *data, int prop_size,
+ int padding)
+{
+ const char *val = data;
+ int i;
+
+ g_string_append_printf(buf, "%*s%s = [", padding, "", propname);
+
+ for (i = 0; i < prop_size; i++) {
+ g_string_append_printf(buf, "%02x", val[i]);
+ if (i < prop_size - 1) {
+ g_string_append_printf(buf, " ");
+ }
+ }
+
+ g_string_append_printf(buf, "];\n");
+}
+
static void fdt_format_node(GString *buf, int node, int depth)
{
const struct fdt_property *prop = NULL;
@@ -738,11 +784,20 @@ static void fdt_format_node(GString *buf, int node, int
depth)
prop = fdt_get_property_by_offset(fdt, property, &prop_size);
propname = fdt_string(fdt, fdt32_to_cpu(prop->nameoff));
+ if (prop_size == 0) {
+ g_string_append_printf(buf, "%*s%s;\n", padding, "", propname);
+ continue;
+ }
+
if (fdt_prop_is_string_array(prop->data, prop_size)) {
fdt_prop_format_string_array(buf, propname, prop->data,
prop_size, padding);
+ } else if (fdt_prop_is_uint32_array(prop_size)) {
+ fdt_prop_format_uint32_array(buf, propname, prop->data, prop_size,
+ padding);
} else {
- g_string_append_printf(buf, "%*s%s;\n", padding, "", propname);
+ fdt_prop_format_val(buf, propname, prop->data,
+ prop_size, padding);
}
}
--
2.37.2
- Re: [PATCH for-7.2 v4 10/21] hw/ppc: set machine->fdt in spapr machine, (continued)
- [PATCH for-7.2 v4 15/21] qmp/hmp, device_tree.c: introduce 'info fdt' command, Daniel Henrique Barboza, 2022/08/26
- Re: [PATCH for-7.2 v4 15/21] qmp/hmp, device_tree.c: introduce 'info fdt' command, David Gibson, 2022/08/28
- Re: [PATCH for-7.2 v4 15/21] qmp/hmp, device_tree.c: introduce 'info fdt' command, Daniel Henrique Barboza, 2022/08/29
- Re: [PATCH for-7.2 v4 15/21] qmp/hmp, device_tree.c: introduce 'info fdt' command, David Gibson, 2022/08/29
- Re: [PATCH for-7.2 v4 15/21] qmp/hmp, device_tree.c: introduce 'info fdt' command, Daniel Henrique Barboza, 2022/08/30
- Re: [PATCH for-7.2 v4 15/21] qmp/hmp, device_tree.c: introduce 'info fdt' command, Markus Armbruster, 2022/08/30
- Re: [PATCH for-7.2 v4 15/21] qmp/hmp, device_tree.c: introduce 'info fdt' command, Markus Armbruster, 2022/08/30
[PATCH for-7.2 v4 14/21] qmp/hmp, device_tree.c: introduce dumpdtb, Daniel Henrique Barboza, 2022/08/26
[PATCH for-7.2 v4 17/21] device_tree.c: support remaining FDT prop types,
Daniel Henrique Barboza <=
[PATCH for-7.2 v4 19/21] device_tree.c: add fdt_format_property() helper, Daniel Henrique Barboza, 2022/08/26
[PATCH for-7.2 v4 20/21] hmp, device_tree.c: add 'info fdt <property>' support, Daniel Henrique Barboza, 2022/08/26
[PATCH for-7.2 v4 21/21] qmp/hmp, device_tree.c: add textformat dumpdtb option, Daniel Henrique Barboza, 2022/08/26