Re: [PATCH 16/18] i386: Rewrite blendv helpers

[Richard Henderson]

On 8/25/22 15:14, Paolo Bonzini wrote:
> +#define BLEND_I128(elem, num, F, b) do {                                    \
> +    d->elem(b + 0) = F(v->elem(b + 0), s->elem(b + 0), ((imm >> 0) & 1));   \
> +    d->elem(b + 1) = F(v->elem(b + 1), s->elem(b + 1), ((imm >> 1) & 1));   \
> +    if (num > 2) {                                                          \
> +        d->elem(b + 2) = F(v->elem(b + 2), s->elem(b + 2), ((imm >> 2) & 1)); \
> +        d->elem(b + 3) = F(v->elem(b + 3), s->elem(b + 3), ((imm >> 3) & 1)); \
> +    }                                                                       \
> +    if (num > 4) {                                                          \
> +        d->elem(b + 4) = F(v->elem(b + 4), s->elem(b + 4), ((imm >> 4) & 1)); \
> +        d->elem(b + 5) = F(v->elem(b + 5), s->elem(b + 5), ((imm >> 5) & 1)); \
> +        d->elem(b + 6) = F(v->elem(b + 6), s->elem(b + 6), ((imm >> 6) & 1)); \
> +        d->elem(b + 7) = F(v->elem(b + 7), s->elem(b + 7), ((imm >> 7) & 1)); \
> +    }                                                                       \
> +    } while (0)

Unused?  It certainly seems redundant with...

>   #define SSE_HELPER_I(name, elem, num, F)                                \
> +    void glue(name, SUFFIX)(CPUX86State *env, Reg *d, Reg *s,   \
> +                            uint32_t imm)                               \
>       {                                                                   \
> +        Reg *v = d;                                                     \
> +        int i;                                                          \
> +        for (i = 0; i < num; i++) {                                     \
> +            int j = i & 7;                                              \
> +            d->elem(i) = F(v->elem(i), s->elem(i), (imm >> j) & 1);     \
>           }                                                               \
>       }

... this.

Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~