qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v1 22/25] tests/docker: update and flatten debian-toolchain


From: Alex Bennée
Subject: Re: [PATCH v1 22/25] tests/docker: update and flatten debian-toolchain
Date: Sat, 27 Aug 2022 10:32:22 +0100
User-agent: mu4e 1.9.0; emacs 28.1.91

Thomas Huth <thuth@redhat.com> writes:

> On 26/08/2022 19.21, Alex Bennée wrote:
>> Update to the latest stable Debian. While we are at it flatten into a
>> single dockerfile as we do not need anything from the base image to
>> build the toolchain. This is used to build both the nios and
>> microblaze toolchains.
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> ---
>>   tests/docker/Makefile.include                    | 4 ----
>>   tests/docker/dockerfiles/debian-toolchain.docker | 5 +++--
>>   2 files changed, 3 insertions(+), 6 deletions(-)
>
> I was a little bit surprised that we do not expose these containers in
> the gitlab-CI (and thus that there are no modifications to the yml
> files here), but seems like we're fine.

Only because the toolchain containers are built and uploaded by hand
because they take so long.

>
> Reviewed-by: Thomas Huth <thuth@redhat.com>


-- 
Alex Bennée



reply via email to

[Prev in Thread] Current Thread [Next in Thread]