[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/1] monitor/hmp: print trace as option in help for log comma
From: |
Dongli Zhang |
Subject: |
Re: [PATCH 1/1] monitor/hmp: print trace as option in help for log command |
Date: |
Mon, 29 Aug 2022 10:36:26 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 |
Sorry that the format for "none" should be changed as well.
I have sent a v2:
https://lists.gnu.org/archive/html/qemu-devel/2022-08/msg04445.html
Thank you very much!
Dongli Zhang
On 8/29/22 3:04 AM, Dongli Zhang wrote:
> The below is printed when printing help information in qemu-system-x86_64
> command line, and when CONFIG_TRACE_LOG is enabled:
>
> $ qemu-system-x86_64 -d help
> ... ...
> trace:PATTERN enable trace events
>
> Use "-d trace:help" to get a list of trace events.
>
> However, they are not printed in hmp "help log" command.
>
> Cc: Joe Jin <joe.jin@oracle.com>
> Signed-off-by: Dongli Zhang <dongli.zhang@oracle.com>
> ---
> monitor/hmp.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/monitor/hmp.c b/monitor/hmp.c
> index 15ca047..9f48b70 100644
> --- a/monitor/hmp.c
> +++ b/monitor/hmp.c
> @@ -287,8 +287,13 @@ void help_cmd(Monitor *mon, const char *name)
> monitor_printf(mon, "Log items (comma separated):\n");
> monitor_printf(mon, "%-10s %s\n", "none", "remove all logs");
> for (item = qemu_log_items; item->mask != 0; item++) {
> - monitor_printf(mon, "%-10s %s\n", item->name, item->help);
> + monitor_printf(mon, "%-15s %s\n", item->name, item->help);
> }
> +#ifdef CONFIG_TRACE_LOG
> + monitor_printf(mon, "trace:PATTERN enable trace events\n");
> + monitor_printf(mon, "\nUse \"info trace-events\" to get a list
> of "
> + "trace events.\n\n");
> +#endif
> return;
> }
>
>