Re: [PATCH v8 3/7] block: add block layer APIs resembling Linux ZonedBlockDevice ioctls

[Markus Armbruster]

Sam Li <faithilikerun@gmail.com> writes:

> Markus Armbruster <armbru@redhat.com> 于2022年8月30日周二 19:57写道：
>>
>> Sam Li <faithilikerun@gmail.com> writes:
>>
>> > By adding zone management operations in BlockDriver, storage controller
>> > emulation can use the new block layer APIs including Report Zone and
>> > four zone management operations (open, close, finish, reset).
>> >
>> > Add zoned storage commands of the device: zone_report(zrp), zone_open(zo),
>> > zone_close(zc), zone_reset(zrs), zone_finish(zf).
>> >
>> > For example, to test zone_report, use following command:
>> > $ ./build/qemu-io --image-opts driver=zoned_host_device, 
>> > filename=/dev/nullb0
>> > -c "zrp offset nr_zones"
>> >
>> > Signed-off-by: Sam Li <faithilikerun@gmail.com>
>> > Reviewed-by: Hannes Reinecke <hare@suse.de>

[...]

>> > diff --git a/qapi/block-core.json b/qapi/block-core.json
>> > index 2173e7734a..c6bbb7a037 100644
>> > --- a/qapi/block-core.json
>> > +++ b/qapi/block-core.json
>> > @@ -2942,6 +2942,7 @@
>> >  # @compress: Since 5.0
>> >  # @copy-before-write: Since 6.2
>> >  # @snapshot-access: Since 7.0
>> > +# @zoned_host_device: Since 7.2
>> >  #
>> >  # Since: 2.9
>> >  ##
>> > @@ -2955,7 +2956,8 @@
>> >              'luks', 'nbd', 'nfs', 'null-aio', 'null-co', 'nvme', 
>> > 'parallels',
>> >              'preallocate', 'qcow', 'qcow2', 'qed', 'quorum', 'raw', 'rbd',
>> >              { 'name': 'replication', 'if': 'CONFIG_REPLICATION' },
>> > -            'ssh', 'throttle', 'vdi', 'vhdx', 'vmdk', 'vpc', 'vvfat' ] }
>> > +            'ssh', 'throttle', 'vdi', 'vhdx', 'vmdk', 'vpc', 'vvfat',
>> > +            { 'name': 'zoned_host_device', 'if': 'CONFIG_BLKZONED' } ] }
>>
>> QAPI naming conventions ask for 'zoned-host-device'.  We may choose to
>> ignore them to stay closer to existing 'host_device'.
>
> I am not sure why should ignore zoned_host_device. Can you be more specific?

"them" = QAPI naming conventions.  Clear now?

[...]