|
From: | Chuang Xu |
Subject: | Re: [External] Re: [RFC PATCH] migration: reduce time of loading non-iterable vmstate |
Date: | Fri, 9 Dec 2022 06:33:24 -0800 |
User-agent: | Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 |
Hi, Peter! This email is a supplement to my previous email 7 hours ago.
If the assert will work that'll be even better. I'm actually worried this can trigger like what you mentioned in the virtio path, I didn't expect it comes that soon. So if there's a minimum cases and we can fixup easily that'll be great. Hopefully there aren't so much or we'll need to revisit the whole idea. Thanks,
Only delaying virtio_init_region_cache() will result in the failure of the checks and caches following original virtio_init_region_cache(). Here are the patches related to these checks and cache operation: https://gitlab.com/qemu-project/qemu/-/commit/1abeb5a65d515f8a8a9cfc4a82342f731bd9321f https://gitlab.com/qemu-project/qemu/-/commit/be1fea9bc286f64c6c995bb0d7145a0b738aeddb https://gitlab.com/qemu-project/qemu/-/commit/b796fcd1bf2978aed15748db04e054f34789e9eb https://gitlab.com/qemu-project/qemu/-/commit/bccdef6b1a204db0f41ffb6e24ce373e4d7890d4 I think I should try to postpone these checks and caches too.. Thanks!
[Prev in Thread] | Current Thread | [Next in Thread] |