Re: [PATCH v5 08/12] cryptodev: Use CryptoDevBackendOpInfo for operation

[Daniel P . Berrangé]

On Wed, Mar 01, 2023 at 10:51:20AM +0800, zhenwei pi wrote:
> Move queue_index, CryptoDevCompletionFunc and opaque into struct
> CryptoDevBackendOpInfo, then cryptodev_backend_crypto_operation()
> needs an argument CryptoDevBackendOpInfo *op_info only. And remove
> VirtIOCryptoReq from cryptodev. It's also possible to hide
> VirtIOCryptoReq into virtio-crypto.c in the next step. (In theory,
> VirtIOCryptoReq is a private structure used by virtio-crypto only)
> 
> Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
> ---
>  backends/cryptodev-builtin.c |  9 +++------
>  backends/cryptodev-lkcf.c    |  9 +++------
>  backends/cryptodev.c         | 18 +++++-------------
>  hw/virtio/virtio-crypto.c    |  7 ++++---
>  include/sysemu/cryptodev.h   | 26 ++++++++++----------------
>  5 files changed, 25 insertions(+), 44 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|