[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 07/10] qapi: implement conditional command arguments
|
From: |
Marc-André Lureau |
|
Subject: |
Re: [PATCH v3 07/10] qapi: implement conditional command arguments |
|
Date: |
Wed, 1 Mar 2023 17:21:43 +0400 |
Hi
On Wed, Mar 1, 2023 at 5:16 PM Markus Armbruster <armbru@redhat.com> wrote:
> What about 3. have an additional command conditional on CONFIG_WIN32?
> Existing getfd stays the same: always fails when QEMU runs on a Windows
> host. The new command exists only when QEMU runs on a Windows host.
This is what was suggested initially:
https://patchew.org/QEMU/20230103110814.3726795-1-marcandre.lureau@redhat.com/20230103110814.3726795-9-marcandre.lureau@redhat.com/
I also like it better, as a specific command for windows sockets, less
ways to use it wrongly.
--
Marc-André Lureau