qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] ui/sdl2: remove workaround forcing x11


From: Daniel P . Berrangé
Subject: Re: [PATCH] ui/sdl2: remove workaround forcing x11
Date: Wed, 1 Mar 2023 14:41:54 +0000
User-agent: Mutt/2.2.9 (2022-11-12)

On Wed, Mar 01, 2023 at 03:12:05PM +0100, Erico Nunes wrote:
> This workaround was put in place in the original implementation almost
> 10 years ago, considering a very old SDL2 version. Currently it prevents
> users to run in a wayland-only environment without manually forcing the
> backend.
> The SDL2 wayland backend has been supported by distributions for a very
> long time (e.g. in Fedora, first available 8 years ago), and is now
> considered stable and becoming the default for new SDL2 releases.
> Instead of requiring the x11 backend to exist by default, let new qemu
> releases run with the default chosen by the installed SDL2 version.

As the comment says, it is better fixed elsewhere anyway rather
than hardcoding in QEMU

> 
> Signed-off-by: Erico Nunes <ernunes@redhat.com>
> ---
>  ui/sdl2.c | 16 ----------------
>  1 file changed, 16 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




reply via email to

[Prev in Thread] Current Thread [Next in Thread]